Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Process Console #3338

Merged
merged 10 commits into from
Dec 9, 2022
Merged

Document the Process Console #3338

merged 10 commits into from
Dec 9, 2022

Conversation

JADarius
Copy link
Contributor

@JADarius JADarius commented Nov 30, 2022

Pull Request Overview

This pull request adds documentation for the process_console capsule so that it can be easier for new users to get started. I also found a typo in the comments of process_console.rs.

Testing Strategy

N/A

TODO or Help Wanted

This pull request still needs a review and suggestions for possible improvement.

Documentation Updated

  • Added the relevant file in /doc.

Formatting

  • Ran make prepush.

Copy link
Contributor

@bradjc bradjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Also please add a link from doc/README.md.

capsules/src/process_console.rs Outdated Show resolved Hide resolved
doc/Process_Console.md Outdated Show resolved Hide resolved
doc/Process_Console.md Outdated Show resolved Hide resolved
doc/Process_Console.md Outdated Show resolved Hide resolved
doc/Process_Console.md Outdated Show resolved Hide resolved
@JADarius JADarius requested review from alexandruradovici and bradjc and removed request for alexandruradovici December 2, 2022 18:13
doc/Process_Console.md Outdated Show resolved Hide resolved
doc/Process_Console.md Outdated Show resolved Hide resolved
capsules/src/process_console.rs Outdated Show resolved Hide resolved
@JADarius
Copy link
Contributor Author

JADarius commented Dec 2, 2022

I have made the requested changes.

@JADarius JADarius requested a review from bradjc December 2, 2022 21:44
@JADarius JADarius requested a review from bradjc December 5, 2022 19:37
@bradjc bradjc added the last-call Final review period for a pull request. label Dec 5, 2022
@hudson-ayers
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 9, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
last-call Final review period for a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants