Increased the stack memory for the microbit board because of stack overflow #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
approved these changes
Nov 30, 2022
twilfredo
approved these changes
Nov 30, 2022
bradjc
approved these changes
Dec 1, 2022
lschuermann
approved these changes
Dec 4, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
On the microbit v2 board, the command
process ncaused a stack overflow which panics the kernel. This pull request fixes the stack memory needed for the Process Console on the microbit board. The value was obtained by slowly incrementing the stack memory until the commandprocess ndidn't cause a stack overflow so that it would be the minimum necessary.I have attached the output of the command.
Testing Strategy
This pull request was tested by running the
processcommand on a microbit v2 board with ablinkmodule from thelibtock-cexamples installed and by modifying the value of the memory until the stack overflow was removed.TODO or Help Wanted
This pull request still needs some testing on other microbit boards to be sure that the kernel panic wasn't caused by faulty equipment.
Documentation Updated
Formatting
make prepush.