Make tools/ a cargo workspace.
#3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cargo workspace was created in PR tock#1714. tock#1714's description asked the question "Should `tools/` also be part of the workspace? Have their own workspace?", which doesn't appear to have been answered. The PR ultimately excluded `tools/` from the root workspace. I think `tools/` would benefit from being in a cargo workspace. Because the root workspace specifies compilation profiles that are tuned for embedded code, I decided to make a second workspace for `tools/`. I am open to making `tools/` part of the root workspace if that's what you would prefer.
hudson-ayers
previously approved these changes
Dec 1, 2022
…ols.sh`. `tools/list_tools.sh` incorrectly indicates that `tools/` itself is a Cargo package, which resulted in CI errors. This removes the manual iteration and instead uses `cargo` to find the tools.
bradjc
approved these changes
Dec 1, 2022
alistair23
approved these changes
Dec 1, 2022
hudson-ayers
approved these changes
Dec 1, 2022
twilfredo
approved these changes
Dec 4, 2022
lschuermann
approved these changes
Dec 4, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
The root cargo workspace was created in PR #1714. #1714's description asked the question "Should
tools/also be part of the workspace? Have their own workspace?", which doesn't appear to have been answered.This PR makes
tools/its own cargo workspace.Testing Strategy
Ran
cargo check --workspace --exclude litex-ci-runnerintools/(I excludedlitex-ci-runneras it requires a dependency I don't have installed).Ran
cargo checkin the root of the repository.Ran
make prepush.Open Questions
Do we want to make
tools/part of the root workspace rather than making it its own workspace? I made it a separate workspace because the compilation profiles in the root workspace are intended for embedded code, whereastools/is host-side code, but I'm open to making it all one workspace. Building host-side tools with embedded profiles will make things a bit slower but shouldn't break anything (unless something relies on panic unwinding).Documentation Updated
/docs, or no updates are required.Formatting
make prepush.