Implementation of PWM functionality for RP2040. #3372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
This was referenced Jan 9, 2023
hudson-ayers
approved these changes
Jan 18, 2023
twilfredo
approved these changes
Jan 23, 2023
alexandruradovici
approved these changes
Jan 23, 2023
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 25, 2023
3366: Add core WG notes for 2022-12-16. r=hudson-ayers a=jrvanwhy [Rendered](https://github.com/jrvanwhy/tock/blob/core-notes-2022-12-16/doc/wg/core/notes/core-notes-2022-12-16.md) 3368: ADC pending command functionality r=hudson-ayers a=TeodoraMiu ### Pull Request Overview This pull request changes the way the ADC capsule receives commands from apps. Before this PR, the ADC capsule could only handle one command at a time. This PR would allow the ADC capsule to set an incoming command as pending if the requested ADC channel is already in use, and run the pending command after the currently active command finishes. ### Testing Strategy This pull request was tested on a Microbit, using a fake ADC driver to simulate the case in which two commands can overlap. ### TODO or Help Wanted Feedback is greatly appreciated. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3372: Implementation of PWM functionality for RP2040. r=hudson-ayers a=Ioan-Cristian ### Pull Request Overview This pull request adds PWM functionality to RP2040. ### Testing Strategy This pull request was tested using both unit test and integration tests on Raspberry Pi Pico W. The unit tests can be found inside chips/rp2040/src/pwm.rs and the integration tests in chips/rp2040/src/test/pwm.rs ### TODO or Help Wanted Running tests on other RP2040-based MCUs. ### Documentation Updated - [x] Added relevant documentation files. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Johnathan Van Why <jrvanwhy@google.com> Co-authored-by: TeodoraMiu <teodora.miu01@gmail.com> Co-authored-by: Teodora Miu <96741919+TeodoraMiu@users.noreply.github.com> Co-authored-by: Ioan-Cristian CÎRSTEA <ioan-cristian.cirstea@tutanota.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Jan 26, 2023
3368: ADC pending command functionality r=hudson-ayers a=TeodoraMiu ### Pull Request Overview This pull request changes the way the ADC capsule receives commands from apps. Before this PR, the ADC capsule could only handle one command at a time. This PR would allow the ADC capsule to set an incoming command as pending if the requested ADC channel is already in use, and run the pending command after the currently active command finishes. ### Testing Strategy This pull request was tested on a Microbit, using a fake ADC driver to simulate the case in which two commands can overlap. ### TODO or Help Wanted Feedback is greatly appreciated. ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. 3372: Implementation of PWM functionality for RP2040. r=hudson-ayers a=Ioan-Cristian ### Pull Request Overview This pull request adds PWM functionality to RP2040. ### Testing Strategy This pull request was tested using both unit test and integration tests on Raspberry Pi Pico W. The unit tests can be found inside chips/rp2040/src/pwm.rs and the integration tests in chips/rp2040/src/test/pwm.rs ### TODO or Help Wanted Running tests on other RP2040-based MCUs. ### Documentation Updated - [x] Added relevant documentation files. ### Formatting - [x] Ran `make prepush`. Co-authored-by: TeodoraMiu <teodora.miu01@gmail.com> Co-authored-by: Teodora Miu <96741919+TeodoraMiu@users.noreply.github.com> Co-authored-by: Ioan-Cristian CÎRSTEA <ioan-cristian.cirstea@tutanota.com>
|
@Ioan-Cristian can you please fix the conflicts. |
github-actions
bot
added
documentation
and removed
HIL
I think I fixed them. Sorry for the delay! |
|
This seems to be merged, but not closed. @hudson-ayers this might be a bors issue. |
|
Yeah, confirmed this did in fact get merged into master, but failed to close as merged..just going to close this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request adds PWM functionality to RP2040.
Testing Strategy
This pull request was tested using both unit test and integration tests on Raspberry Pi Pico W. The unit tests can be found inside chips/rp2040/src/pwm.rs and the integration tests in chips/rp2040/src/test/pwm.rs
TODO or Help Wanted
Running tests on other RP2040-based MCUs.
Documentation Updated
Formatting
make prepush.