Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: fix to follow the implied_bounds_entailment #3393

Conversation

alexandruradovici
Copy link
Contributor

Pull Request Overview

This pull request (hopefully) fixes the implied impl bounds. It updates the ListNode impl for MLFQProcessNode and Deref impl for StaticRef following this rust compiler update. Without this fix, Tock cannot be built on newer Rust versions.

Testing Strategy

Tock builds now, I think it should be right.

TODO or Help Wanted

Feedback from someone understanding better the lifetime definitions would be great.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the kernel label Feb 3, 2023
@bradjc
Copy link
Contributor

bradjc commented Feb 3, 2023

I like it :)

@alexandruradovici
Copy link
Contributor Author

I saw your PRs now 😃

@hudson-ayers
Copy link
Contributor

I am closing this in favor of Brad's PRs since I think the StaticRef example is qualitatively different than the MLFQ change (which was basically just a typo) and because those PRs have already gotten reviews

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants