-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the I2C implementation to use generics #3431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed how it makes sense to get this inline with SPI.
bors r+ |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Pull Request Overview
This pull request modifies the I2C HIL and capsules to use generics.
Code sizes:
Old imix:
text data bss dec hex
175092 0 28568 203660 31b8c
New imix:
text data bss dec hex
174836 0 28556 203392 31a80
Old microbit:
text data bss dec hex
106500 0 15788 122288 1ddb0
New microbit:
text data bss dec hex
106500 0 15772 122272 1dda0
Old stm32f3discovery:
text data bss dec hex
100356 0 16632 116988 1c8fc
New stm32f3discovery:
text data bss dec hex
100356 0 16616 116972 1c8ec
Old hifive:
text data bss dec hex
77388 12 7320 84720 14af0
New hifive:
text data bss dec hex
75276 12 6932 82220 1412c
Pros
Cons
SMBus
was optional, this uses an "empty" implementation.TODO or Help Wanted
Feedback would be highly appreciated.
Documentation Updated
Formatting
make prepush
.