Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

siphash24: add test #3473

Merged
merged 1 commit into from
Jun 9, 2023
Merged

siphash24: add test #3473

merged 1 commit into from
Jun 9, 2023

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Jun 7, 2023

Pull Request Overview

This pull request adds a simple test for the SipHash24 software hash capsule.

Testing Strategy

Running the test on the nrf52840dk.

TODO or Help Wanted

n/a

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@ppannuto ppannuto added the P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. label Jun 9, 2023
@ppannuto
Copy link
Member

ppannuto commented Jun 9, 2023

bors r+

bors bot added a commit that referenced this pull request Jun 9, 2023
3464: capsules: remove lingering pub static mut r=ppannuto a=bradjc

### Pull Request Overview

This includes some comments as well as a few remaining static mut buffers used by boards.


Fixes #1545.







### Testing Strategy

travis


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make prepush`.


3473: siphash24: add test r=ppannuto a=bradjc

### Pull Request Overview

This pull request adds a simple test for the SipHash24 software hash capsule.


### Testing Strategy

Running the test on the nrf52840dk.


### TODO or Help Wanted

n/a


### Documentation Updated

- [x] Updated the relevant files in `/docs`, or no updates are required.

### Formatting

- [x] Ran `make prepush`.


Co-authored-by: Brad Campbell <bradjc5@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jun 9, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@ppannuto
Copy link
Member

ppannuto commented Jun 9, 2023

bors retry

@bors
Copy link
Contributor

bors bot commented Jun 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bradjc bradjc merged commit 341f41f into master Jun 9, 2023
24 checks passed
@bors bors bot deleted the sip-hash-test branch June 9, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants