Update EOL GitHub Actions dependencies #3591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request updates GitHub Actions dependencies which use Node v12 (which will stop working soon) to Node v16.
GitHub will remove Node v12 from the action runners on the 14th of August.
Testing Strategy
All the updated workflows run
on: pull_request
, so if this PR passes then the CI still works.I checked the major-version release notes of the updated actions and didn't see any breaking changes apart from updating Node v12 to Node v16.
I see that one workflow is using actions/setup-node so there could be breakage here.
TODO or Help Wanted
There is one action left that hasn't been updated to Node v16 (actions-rs/toolchain) which doesn't seem to be maintained any more. It's used in most workflows.
There's a replacement action called dtolnay/rust-toolchain, but I'm not sure it supports using the toolchain specified in
rust-toolchain
.I think GitHub's container comes with
rustup
, so you could potentially drop this action if the repo had arust-toolchain.toml
which specified the required components. The rustc update script currently depends on this being a plaintext file, so would need updating.Documentation Updated
/docs
, or no updates are required.Formatting
make prepush
.