Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EOL GitHub Actions dependencies #3591

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Aug 4, 2023

Pull Request Overview

This pull request updates GitHub Actions dependencies which use Node v12 (which will stop working soon) to Node v16.

GitHub will remove Node v12 from the action runners on the 14th of August.

Testing Strategy

All the updated workflows run on: pull_request, so if this PR passes then the CI still works.

I checked the major-version release notes of the updated actions and didn't see any breaking changes apart from updating Node v12 to Node v16.

I see that one workflow is using actions/setup-node so there could be breakage here.

TODO or Help Wanted

There is one action left that hasn't been updated to Node v16 (actions-rs/toolchain) which doesn't seem to be maintained any more. It's used in most workflows.

There's a replacement action called dtolnay/rust-toolchain, but I'm not sure it supports using the toolchain specified in rust-toolchain.

I think GitHub's container comes with rustup, so you could potentially drop this action if the repo had a rust-toolchain.toml which specified the required components. The rustc update script currently depends on this being a plaintext file, so would need updating.

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

These versions of the actions used Node v12 which will be removed from
GitHub's action runners on the 14th of August.
Copy link
Member

@ppannuto ppannuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an easy yes, thanks!

W.r.t. the toolchain version and its action, I'll make a separate PR on that in a little bit — it looks like the new rust-toolchain.toml also supports explicit lists of required components and versions; we currently have a bunch of make machinery that that could displace as well, which is exciting.

@ppannuto ppannuto added this pull request to the merge queue Aug 4, 2023
Merged via the queue into tock:master with commit 133cbba Aug 4, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants