Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAX17205 Driver #361

Merged
merged 2 commits into from Jun 21, 2017
Merged

Add MAX17205 Driver #361

merged 2 commits into from Jun 21, 2017

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Apr 24, 2017

Also used on Signpost.

@alevy
Copy link
Member

alevy commented Apr 24, 2017

Is this basically just copy-pasted from Signpost? If so, do we want to just merge as is an iterate as we feel useful? Or do we want to iterate within the pull request?

I'm asking because I have stylistic comments (mostly requesting more descriptive comments, etc) as well as some questions about the organization (e.g. whether this would be better split up into a peripheral driver and system call driver given our experience with the accelerometer).

However, I also don't really mind merging first and iterating later as this clearly works reasonably well enough for signpost.

@alevy
Copy link
Member

alevy commented Apr 24, 2017

BTW this question kind of also goes for the other outstanding driver pull requests from @bradjc

@brghena
Copy link
Contributor

brghena commented Apr 25, 2017

It seems to me that if there are changes we want to make these better technically or aesthetically, we might as well handle them now. It's not like we're going to have more time in the future.

@ppannuto
Copy link
Member

Agree with @brghena. This is code that we know works, but would like to upstream. It's kinda the definition of the upstreaming process to massage code into something that's compatible with the upstream code base / ideals. Especially the stylistic stuff, as we'd like code in Tock master to be representative of best practices as much as possible IMO.

@alevy
Copy link
Member

alevy commented Apr 26, 2017

OK, will do a proper review of these and the other drivers then

@alevy alevy mentioned this pull request May 10, 2017
@alevy
Copy link
Member

alevy commented May 19, 2017

Ditto here as with #359 (+ fix conflicts)

@bradjc
Copy link
Contributor Author

bradjc commented May 23, 2017

Ditto here as with #359 (+ fix conflicts)

@nealjack Can you help with this?

@bradjc
Copy link
Contributor Author

bradjc commented Jun 21, 2017

Updated.

@alevy alevy merged commit f607c06 into master Jun 21, 2017
@alevy alevy deleted the max17205 branch June 21, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants