-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAX17205 Driver #361
Add MAX17205 Driver #361
Conversation
Is this basically just copy-pasted from Signpost? If so, do we want to just merge as is an iterate as we feel useful? Or do we want to iterate within the pull request? I'm asking because I have stylistic comments (mostly requesting more descriptive comments, etc) as well as some questions about the organization (e.g. whether this would be better split up into a peripheral driver and system call driver given our experience with the accelerometer). However, I also don't really mind merging first and iterating later as this clearly works reasonably well enough for signpost. |
BTW this question kind of also goes for the other outstanding driver pull requests from @bradjc |
It seems to me that if there are changes we want to make these better technically or aesthetically, we might as well handle them now. It's not like we're going to have more time in the future. |
Agree with @brghena. This is code that we know works, but would like to upstream. It's kinda the definition of the upstreaming process to massage code into something that's compatible with the upstream code base / ideals. Especially the stylistic stuff, as we'd like code in Tock master to be representative of best practices as much as possible IMO. |
OK, will do a proper review of these and the other drivers then |
Ditto here as with #359 (+ fix conflicts) |
Updated. |
Also used on Signpost.