Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sam4l: trng: update to new reg interface #785

Merged
merged 1 commit into from Mar 7, 2018
Merged

Conversation

bradjc
Copy link
Contributor

@bradjc bradjc commented Mar 7, 2018

Pull Request Overview

This pull request converts the RNG on SAM4L to new register interface.

Testing Strategy

This pull request was tested by running the rng test app.

Formatting

  • Ran make formatall.

@bradjc bradjc added sam4l Change pertains to the SAM4L MCU. P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. labels Mar 7, 2018
@@ -25,7 +47,7 @@ pub struct Trng<'a> {
}

pub static mut TRNG: Trng<'static> = Trng::new();
const KEY: u32 = 0x524e4700;
const KEY: u32 = 0x524e47;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the 8 least significant zeros were padding so that it didn't have to be shifted each time.

@ppannuto ppannuto merged commit e705e72 into master Mar 7, 2018
@ppannuto ppannuto deleted the sam4l-new-regs-trng branch March 7, 2018 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-Upkeep This a relatively minor change, or one that is limited in scope, and requires less scrutiny. sam4l Change pertains to the SAM4L MCU.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants