Skip to content

Commit

Permalink
update electron-builder, update README & Publishing docs
Browse files Browse the repository at this point in the history
  • Loading branch information
todbot committed Feb 10, 2018
1 parent afa3af6 commit 912770b
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 21 deletions.
31 changes: 13 additions & 18 deletions Publishing.md
Expand Up @@ -4,35 +4,30 @@ Steps:
- Update version in `package.json` and `app/package.json` (they must match!)
- Build release:
```
npm run clean // removes node_modules so they get rebuilt
npm install // installs & builds node_modules
npm run pack // bundles app code using webpack to bundle.js
rimraf dist
npm run dist // this does the publish, must do it on each OS (Mac,Win,Linux)
npm run clean # removes node_modules so they get rebuilt, does not remove 'dist' dir
npm install # installs & builds node_modules
npm run pack # bundles app code using webpack to bundle.js
rimraf dist # delete previous dist products (optional)
npm run dist # build the dist products, and publish, must do it on each OS (Mac,Win,Linux)
```
- Make release on github (creates tag)
Note: must set GH_TOKEN for `npm run dist` to publish to github

- Edit release on github (tag created by 'dist' above)
- Write release notes (changelog)
- Upload build artifacts
- Publish release
- Check release
- Download each version, unzip / install / launch to test
- Publish announcement

#### Current build machines
- Mac OS X 10.12.6 on Macbook Pro 2013
- Windows 10 Pro (in VM)
- Ubuntu 16.04 (in VM)



#### random notes
- Test out S3 artifact publishing by setting in package.json:
```
"build": {
"publish": {
"provider": "s3",
"bucket": "blink1control2"
}
}
```
and setting `AWS_ACCESS_KEY_ID` & `AWS_SECRET_ACCESS_KEY` environment variable in Travis and Appveyor environment settings
- But for actual publishing, use github releases (default), which requires `GH_TOKEN` secure environment variable and:
- For actual publishing, use github releases (default), which requires `GH_TOKEN` secure environment variable and:
```
"build": {
"publish": {
Expand Down
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -30,7 +30,7 @@ Or to emulate a production run:
npm install # installs all dependencies locally
npm run webpack # packs app, there will be some warnings, ignore
npm run start # starts the packaged app
npm run dist # create relocatable app and installer(s), in "dist" dir
npm run dist:draft # create relocatable app and installer(s), in "dist" dir
```

#### Linux:
Expand All @@ -51,11 +51,11 @@ Install the following pre-requisites:

- libgnome-keyring-dev
- icnsutils
- graphicsmagick
- xz-utils
- rpm
- bsdtar
- libusb-1.0.0-dev
- libudev-dev

(see: https://github.com/electron-userland/electron-builder/issues/1407)

Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -107,7 +107,7 @@
"css-loader": "^0.24.0",
"devtron": "^1.4.0",
"electron": "^1.7.11",
"electron-builder": "19.46.9",
"electron-builder": "^19.56.0",
"electron-builder-squirrel-windows": "19.33.0",
"electron-publisher-s3": "^19.28.3",
"file-loader": "^0.9.0",
Expand Down

0 comments on commit 912770b

Please sign in to comment.