Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for react 18 #3

Merged
merged 7 commits into from
Jul 25, 2022
Merged

Add support for react 18 #3

merged 7 commits into from
Jul 25, 2022

Conversation

coolusaHD
Copy link
Contributor

No description provided.

todd-elvers
todd-elvers reviewed Jul 15, 2022
View reviewed changes
Copy link
Owner

@todd-elvers todd-elvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I added a single comment about the React version in peerDependencies but otherwise this looks great

package.json Outdated Show resolved Hide resolved
@todd-elvers todd-elvers mentioned this pull request Jul 15, 2022
Closed
@coolusaHD
Copy link
Contributor Author

coolusaHD commented Jul 18, 2022 •
edited

should now be workig on both react versions
please recheck before merge @todd-elvers
馃殌

todd-elvers
todd-elvers reviewed Jul 25, 2022
View reviewed changes
Copy link
Owner

@todd-elvers todd-elvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@todd-elvers todd-elvers merged commit fa61541 into todd-elvers:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todd-elvers todd-elvers todd-elvers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coolusaHD @todd-elvers