Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SSR support #7

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Adding SSR support #7

merged 2 commits into from
Jan 9, 2024

Conversation

orinaveh
Copy link
Contributor

#6

@orinaveh
Copy link
Contributor Author

@todd-elvers Can you review my PR?

@indreklasn
Copy link

@todd-elvers

Copy link
Owner

@todd-elvers todd-elvers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Just posed one question regarding vendor prefixing. If vite-plugin-css-injected-by-js handles vendor prefixing just let me know and we can ignore that comment.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with this approach is vendor prefixing. Unless I missing something and vite-plugin-css-injected-by-js handles it for you, what about changing it to the following:

.button {
      cursor: pointer;
      overflow: hidden;
      -webkit-appearance: none;
         -moz-appearance: none;
              appearance: none;
      border: none;
      background-color: transparent;
      padding: 0;
}

.player {
      display: none;
      -webkit-box-align: center;
         -ms-flex-align: center;
            align-items: center;
      -webkit-box-pack: center;
         -ms-flex-pack: center;
       justify-content: center;
}

.player--loaded {
    display: -webkit-box;
    display: -ms-flexbox;
    display: flex;
}

This was linked to issues Jan 9, 2024
@todd-elvers todd-elvers merged commit 4c5a819 into todd-elvers:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR Not Supported Problems installing new version
3 participants