Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET 5.0 changes #389

Merged
merged 2 commits into from
Nov 16, 2020
Merged

.NET 5.0 changes #389

merged 2 commits into from
Nov 16, 2020

Conversation

nm-a
Copy link
Contributor

@nm-a nm-a commented Nov 12, 2020

Hi,
I haven't tested completely, need someone help to test it.

Thank you

@jzabroski
Copy link
Collaborator

@nm-a I am happy to help test it - can you please make the minor changes I asked and then I can look into it hopefully this weekend and release a net5.0 version (I think if the tests pass we just release it and let people give feedback since people are clamoring for .net5.0 in general due to how awesome it is.)

@nm-a
Copy link
Contributor Author

nm-a commented Nov 13, 2020

Hi @jzabroski ,
Thank you for your inputs, I have updated pull request with your suggestions. Please review it once.

Thank you

@jzabroski
Copy link
Collaborator

@nm-a This looks great. I will try to run tests tonight and get back to you.

@jzabroski
Copy link
Collaborator

I'm running the tests now.

@jzabroski jzabroski merged commit f1b31c0 into toddams:master Nov 16, 2020
vdurante pushed a commit to vdurante/RazorLight that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants