Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change targeting for .Net standard 2.0 #392

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Conversation

Vincentvwal
Copy link
Contributor

As in this discussion: #390
Change the targeting for .net standard to be more flexible.

@jzabroski
Copy link
Collaborator

Did you test these changes? I think your first commit isn't valid version syntax in some places so I'm just curious how you determined this was the right fix before committing

@Vincentvwal
Copy link
Contributor Author

Running the tests for the .net Standard 2.0 target gave no error.
A complete solution build also gave no errors.

However i noticed the error as well and changed it.

@jzabroski jzabroski merged commit 883ec48 into toddams:master Nov 18, 2020
@jzabroski jzabroski added this to the 2.0.0-rc.2 milestone Nov 18, 2020
vdurante pushed a commit to vdurante/RazorLight that referenced this pull request Feb 29, 2024
Change targeting for .Net standard 2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants