Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.UriFormatException in DefaultAssemblyDirectoryFormatter #489

Merged
merged 3 commits into from
Jul 13, 2022

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented Jul 12, 2022

Also rename to IAssemblyPathFormatter as it returns the path to the assembly itself, not its directory.

Fixes #481

Rename to `IAssemblyPathFormatter` as it returns the path to the assembly, not its directory.

Fixes toddams#481
Copy link
Collaborator

@jzabroski jzabroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check this. I'm on mobile phone sick in bed with Covid but just trying to give fast feedback

@@ -8,7 +9,7 @@ namespace RazorLight.Tests.Compilation
public class DefaultAssemblyPathFormatterTest
{
private readonly ITestOutputHelper _testOutputHelper;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you missing a Fact attribute. did this actually run in the test suite

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jzabroski It did run, but I have changed them from SkippableFact to just Fact now anyway.

Run on this PR:
image

Latest master build:
image

@Xtansia Xtansia requested a review from jzabroski July 12, 2022 21:31
@jzabroski jzabroski merged commit 3e954d5 into toddams:master Jul 13, 2022
@Xtansia Xtansia deleted the fix/uri-format-exception branch July 13, 2022 02:04
@jzabroski jzabroski added this to the 2.1.0 milestone Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.UriFormatException: Invalid URI: The hostname could not be parsed
2 participants