Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Unregister Bug & Add Functionality to Check Registered Type Converters #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix Unregister Bug & Add Functionality to Check Registered Type Converters #2

wants to merge 4 commits into from

Conversation

jblacker
Copy link

The most important part of this PR is the fix for unregisterTypeConversion(Conversion<?>) where either a NPE would be thrown if a Conversion#getTypeKeys returned null, or it simply would not unregister the conversion if the instance passed is not the same instance as what was originally registered.

Other changes were minor:

  • Relocated unregisterTypeConversion(Object) to be next to its overload
  • Added a method to get a copy of the currently registered type conversions as an immutable map (UnmodifiableMap wrapping a new LinkedHashMap to be precise)
  • Updated .gitignore file to ignore files generated by IntelliJ for it's IDE users (such as myself)

All unit tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jblacker