kill_kill: Immediately KILL the child process as documented for Win32. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TERM signal ends up as a call to GenerateConsoleCtrlEvent() which sends the signal to the entire process group, with confusing results.
toddr
force-pushed
the
master
branch
8 times, most recently
from
b2d4069
to
4ab953f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TERM signal ends up as a call to GenerateConsoleCtrlEvent()
which sends the signal to the entire process group, with
confusing results.
The other option is to follow what the core does for system(1, ...) and create a new process group for each new child.
Note that a few other tests fail, but that doesn't appear to be due to this change.