Tighten the TODO tests

to only the tests which still fail: \u and \/ or SingleQuote
cpan-authors · Apr 18, 2017 · de43df6 · de43df6
1 parent f349f27
commit de43df6
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/t/json-basic.t b/t/json-basic.t
@@ -45,14 +45,14 @@ my @tests = (
     '{"foo":""}',
     '["\"://\""]',
     '"~foo"',
-    { TEST => '"\/"', TODO => "backslashed char not working yet" },    # escaped solidus
+    { TEST => '"\/"',     TODO => "backslashed char not working yet" }, # escaped solidus
     '"\""',
     { TEST => '"\b"',     TODO => "backslashed char not working yet" },
     { TEST => '"\f"',     TODO => "backslashed char not working yet" },
     { TEST => '"\n"',     TODO => "backslashed char not working yet" },
     { TEST => '"\r"',     TODO => "backslashed char not working yet" },
-    { TEST => '"\t"',     TODO => "backslashed char not working yet" },
-    { TEST => '"\u0001"', TODO => "backslashed char not working yet" },
+    { TEST => '"\t"',     TODO => "backslashed \\t not working yet" },
+    { TEST => '"\u0001"', TODO => "backslashed \\u not working yet" },
 );
 
 plan tests => scalar @tests * ( 2 + $HAS_JSON ) * 2;
@@ -67,7 +67,9 @@ TODO: {
 
                 local $TODO;
                 if ( ref $test eq 'HASH' ) {
-                    $TODO = $test->{TODO};
+                    if ($single_quote or substr($test->{TEST},2,1) =~ m|[u/]|) {
+                        $TODO = $test->{TODO};
+                    }
                     $test = $test->{TEST};
                 }
 
@@ -87,7 +89,8 @@ TODO: {
                     s/([,:]) /$1/eg;
                 }
 
-                my $desc = "roundtrip $test -> " . Dumper($data) . " -> $json -> sq:$single_quote utf8:$unicode ";
+                my $desc = "roundtrip $test -> " . Dumper($data)
+                  . " -> $json -> sq:$single_quote utf8:$unicode ";
                 utf8::encode($desc);
                 is $json, $test, $desc;