Adding Venue details for schedule #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the stadium where the game was played
toddrob99
requested changes
Jul 18, 2020
There was a problem hiding this comment.
Thank you for the contribution. I will be happy to include this in the next version, but can you please update ' to " and use .get() to ensure the method will not throw an exception in case the venue data is missing? MLB has a habit of inexplicable data discrepancies, so it's best to guard against missing elements.
This will return None for both if the venue element is missing:
"venue_id": game.get("venue", {}).get("id"),
"venue_name": game.get("venue", {}).get("name"),
|
Updated to use .get() and replaced |
toddrob99
approved these changes
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added in the ID and Name of the Venue from the schedule API. I'm not sure how to run the tests for this (but am willing to learn!).
If there's more that's needed from me on this, please let me know and I'll make necessary changes.
Thanks!