8.5.x #3
Open
8.5.x #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change as trailer headers are read after the body.
Introduce BadRequestException as a sub-class of IOException and the super class of ClientAbortException. This allows Tomcat to differentiate between an invalid request (e.g. invalid HTTP headers) and a request that the user cancelled before it completed.
The primary benefit is that the standard error page mechanism is invoked.
This makes the exception accessible to the ChunkedInputFilter which is step 1 in improving handling of bad requests while parsing parameters in chunked requests.
Random crashes have been observed on some platforms. This is intended to create greater isolation between tests.
Verify toolchain version numbers when verifying a release.
Slight hack to ignore x86 binaries for Tomcat 11.
Also sync check for webapp updates since the same lifecycle operations could cause problems.
The host object should be used since its lifecycle is relevant.
Prior to this change it was possible for errors on the CoyoteOutputStream to be recorded against the wrong response if the response was recycled during the call to realWriteBytes().
When restoring a saved POST request after a successful FORM authentication, ensure that neither the URI, the query string nor the protocol are corrupted when restoring the request body. https://bz.apache.org/bugzilla/show_bug.cgi?id=68495
If a stream uses all of the connection windows and still has content to write, it will now be added to the backlog immediately rather than waiting until the write attempt for the remaining content. Addresses intermittent test failures in the HTTP/2 RFC 9218 test
Triggered if the transformation of a class also triggers loading of the same class.
This allows skipping the next valve in the Catalina pipeline, for conditional execution. This was inspired by BZ 60997, which the rewrite valve can do (set the rewrite valve, then set the semaphore valve next; if match then the semaphore is skipped). Also notice major issue where rewrite is considered to have occurred when the output is identical but equals return false due to type differences.
Handle the case where the JSP engine forwards a request/response to a Servlet that uses an OutputStream rather than a Writer. This was triggering an IllegalStateException on code paths where there was a subsequent attempt to obtain a Writer. This had been returning the correct body but with a 500 response. The older TCKs didn't notice the 500 response. The refactored TCK used in Jakarta EE 11 did.
Note there is a performance issue with Checkstyle 10.13.0 that means checks take ~4x longer
This fixes a JSP TCK test. It is likely a long standing bug but wasn't detected as, prior to Jakarta EE 11, the TCK provided web applications were unpacked prior to test execution.
…l 8.5.x releases.
Note: test failure is intermittent
This broke the TLSCertificateReloadListener
Add new StringUtils.splitCommaSeparated utility method which uses a simple search pattern for comma-separated values instead of a regular expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update