If task is completed, hide details. Also fixed issue with completed t…

…ime formatting
todoroo · Sep 17, 2010 · de51220 · de51220
1 parent 8b93d0a
commit de51220
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/astrid/res/values/styles.xml b/astrid/res/values/styles.xml
@@ -62,6 +62,10 @@
     <style name="TextAppearance.TAd_ItemDueDate_Overdue" parent="TextAppearance.TAd_ItemDueDate">
         <item name="android:textColor">#ffee5555</item>
     </style>
+
+    <style name="TextAppearance.TAd_ItemDueDate_Completed" parent="TextAppearance.TAd_ItemDueDate">
+        <item name="android:textColor">#ff777777</item>
+    </style>
 
     <!-- ============================================== FilterListAdapter == -->
 

diff --git a/astrid/src/com/todoroo/astrid/adapter/TaskAdapter.java b/astrid/src/com/todoroo/astrid/adapter/TaskAdapter.java
@@ -294,7 +294,7 @@ public synchronized void setFieldContentsAndVisibility(View view) {
             } else if(task.isCompleted()) {
                 String dateValue = formatDate(task.getValue(Task.COMPLETION_DATE));
                 dueDateView.setText(r.getString(R.string.TAd_completed, dateValue));
-                dueDateView.setTextAppearance(activity, R.style.TextAppearance_TAd_ItemDetails);
+                dueDateView.setTextAppearance(activity, R.style.TextAppearance_TAd_ItemDueDate_Completed);
                 setVisibility(dueDateView);
             } else {
                 dueDateView.setVisibility(View.GONE);
@@ -325,7 +325,7 @@ public synchronized void setFieldContentsAndVisibility(View view) {
             details = taskDetailLoader.get(task.getId()).toString();
         else
             details = task.getValue(Task.DETAILS);
-        if(TextUtils.isEmpty(details) || DETAIL_SEPARATOR.equals(details)) {
+        if(TextUtils.isEmpty(details) || DETAIL_SEPARATOR.equals(details) || task.isCompleted()) {
             viewHolder.details.setVisibility(View.GONE);
         } else {
             viewHolder.details.setVisibility(View.VISIBLE);