Update client to Java 11 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! There are still tests failing. Any idea why and how to fix these? |
|
Yes, yes, I know almost precisely how to deal with that- sorry, still work on progress and I forgot to mark like that. |
pilec
commented
Feb 18, 2020
| @@ -29,16 +30,16 @@ public void setUp() throws Exception { | |||
| keystore = getTruststore("/certificates/rca15_rsa.der", "/certificates/2qca16_rsa.der"); | |||
| } | |||
|
|
|||
|
|
|||
| @Ignore("Disabled due to expired test certificate as well") | |||
There was a problem hiding this comment.
I put a maximum effort to provide a valid certificate, but I failed - stopped on getting No message with ID "certpath" found in resource bundle
|
Thank you! It is merged now. Fixing the release process currently. |
|
@todvora probably it possible to do it via github actions: https://github.com/samuelmeuli/action-maven-publish |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #40
BC BREAK
after a discusion with @todvora, we decided to drop support of JDK7 to allow JDK10,11. Because used libraries cannot be used in both of them.