Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AnsiColor.DEFAULT instead of AnsiColor.BLACK at the end of banner.txt #5

Closed
JacksonBailey opened this issue Oct 24, 2016 · 1 comment

Comments

@JacksonBailey
Copy link

JacksonBailey commented Oct 24, 2016

The banner.txt is a nice example for how to make colored banners, but at the end [here] I think it should use ${AnsiColor.DEFAULT} instead of ${AnsiColor.BLACK}.

Yes, 99% of the time Black is the default color (or at least close to black) but not always. Most terminals allow setting a different default color than the other colors and that default color may be white, or pink, or anything.

The only reason I am even bringing it up is because this blog post is the first result when Googling "Spring Boot colored banner" (which points to this file) so this is sort of like a reference in a way.

Edit: Actually, ${AnsiStyle.NORMAL} may be even better. I believe it does [0m which I think resets everything (bold, italic, background, foreground, etc.).

@toedter
Copy link
Owner

toedter commented Nov 19, 2016

Thx, changed it to ${AnsiStyle.NORMAL}

@toedter toedter closed this as completed Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants