-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Mica/Acrylic on Windows #2399
Comments
/cc @hwangdev97 |
AFAIK the change of https://github.com/electron/electron/blob/main/docs/api/browser-window.md#winsetbackgroundmaterialmaterial-windows is pretty new and Ops, it looks it is already landed in Electron 24 electron/electron#38361 and will probably will be released in this week. |
Yeah, it is now released in https://github.com/electron/electron/releases/tag/v24.4.0 |
Sure, I will submit this PR as soon as possible. |
Currently, there are still some issues with this feature, it did not achieve the expected effect when I have already provided feedback in the Issue. I will continue to follow up on it. |
@hwangdev97 can you provide your feedback in designers' perspective? |
I think perhaps we should wait and see how Electron handles this bug. |
From a product design perspective, we will provide settings to enable or disable the default title bar, which seems to look good on Windows 11, although some details may need to be improved. I think we can handle this feature after fixing bugs in Electron. Once the new settings are completed, we can provide an option to enable the title bar (while also addressing the details in the screenshot). |
@Daydreamer-riri can you please create a PR so that we can have a look? |
Currently, I just set the backgroundMaterial and transparent values, no further changes have been made. I think I need to know whether the transparent attribute needs to be |
blocked by electron/electron#38454 |
Description
Electron has just merged a PR that adds support for Windows Mica material. I think AFFiNE can follow up on this feature, and I am willing to assist in its implementation.
It is currently unknown when this feature will be released in Electron, but I will continue to keep an eye on it.
Use case
No response
Anything else?
see:
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: