Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

​Support Mica/Acrylic on Windows #2399

Open
1 task done
Daydreamer-riri opened this issue May 16, 2023 · 13 comments
Open
1 task done

​Support Mica/Acrylic on Windows #2399

Daydreamer-riri opened this issue May 16, 2023 · 13 comments
Assignees
Labels
story Features perceivable by end-users type:feat Non-bug feature improvements

Comments

@Daydreamer-riri
Copy link

Daydreamer-riri commented May 16, 2023

Description

Electron has just merged a PR that adds support for Windows Mica material. I think AFFiNE can follow up on this feature, and I am willing to assist in its implementation.

It is currently unknown when this feature will be released in Electron, but I will continue to keep an eye on it.

Use case

No response

Anything else?

see:

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@Daydreamer-riri Daydreamer-riri added type:feat Non-bug feature improvements story Features perceivable by end-users labels May 16, 2023
@himself65
Copy link
Contributor

/cc @hwangdev97

@pengx17
Copy link
Collaborator

pengx17 commented May 23, 2023

AFAIK the change of https://github.com/electron/electron/blob/main/docs/api/browser-window.md#winsetbackgroundmaterialmaterial-windows is pretty new and will land in Electron 26.

Ops, it looks it is already landed in Electron 24 electron/electron#38361 and will probably will be released in this week.

@pengx17
Copy link
Collaborator

pengx17 commented May 25, 2023

Yeah, it is now released in https://github.com/electron/electron/releases/tag/v24.4.0
@Daydreamer-riri you can take your time and create a pr for this one.

@Daydreamer-riri
Copy link
Author

Sure, I will submit this PR as soon as possible.

@Daydreamer-riri
Copy link
Author

Currently, there are still some issues with this feature, it did not achieve the expected effect when titleBarStyle was set to hidden.

I have already provided feedback in the Issue. I will continue to follow up on it.

@Daydreamer-riri
Copy link
Author

Daydreamer-riri commented May 25, 2023

image

Personally, I think the default title bar of Win11 looks pretty good 🫠(although there are some details that need to be addressed). However, there is currently a bug where it cannot be resized.

@pengx17
Copy link
Collaborator

pengx17 commented May 26, 2023

@hwangdev97 can you provide your feedback in designers' perspective?

@Daydreamer-riri
Copy link
Author

I think perhaps we should wait and see how Electron handles this bug.

@hwangdev97
Copy link
Member

From a product design perspective, we will provide settings to enable or disable the default title bar, which seems to look good on Windows 11, although some details may need to be improved. I think we can handle this feature after fixing bugs in Electron. Once the new settings are completed, we can provide an option to enable the title bar (while also addressing the details in the screenshot).

@pengx17
Copy link
Collaborator

pengx17 commented May 29, 2023

@Daydreamer-riri can you please create a PR so that we can have a look?

@Daydreamer-riri
Copy link
Author

@Daydreamer-riri can you please create a PR so that we can have a look?

Currently, I just set the backgroundMaterial and transparent values, no further changes have been made.

I think I need to know whether the transparent attribute needs to be true after electron fix this bug.

@pengx17
Copy link
Collaborator

pengx17 commented Aug 23, 2023

blocked by electron/electron#38454

@affine-issue-bot
Copy link

Issue Status: 🙋 Upvoting

🙋 Upvoting

We are currently evaluating demand for the issue and checking whether it requires complicated or risky changes. Please leave a vote or comment if you think it should be prioritized.

This is an automatic reply by the bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Features perceivable by end-users type:feat Non-bug feature improvements
Projects
Status: 🙋 Upvoting
Development

No branches or pull requests

4 participants