Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error style of sidebar #1981

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: error style of sidebar #1981

merged 1 commit into from
Apr 17, 2023

Conversation

QiShaoXuan
Copy link
Contributor

No description provided.

@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:43 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:43 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 17, 2023 6:48am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 6:48am

@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:43 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:43 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:43 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan requested a review from JimmFly April 17, 2023 06:44
@perfsee
Copy link

perfsee bot commented Apr 17, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master         fix/ui                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB       +87 B(+0.00%)   
< Initial JS          1.89 MB        1.89 MB       +87 B(+0.00%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master         fix/ui                 +/- ##
===================================================================
< Bundle              4.17 MB        4.17 MB       +87 B(+0.00%)   
< Initial JS          1.79 MB        1.79 MB       +87 B(+0.00%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master         fix/ui                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 17, 2023 06:45 Inactive
@QiShaoXuan QiShaoXuan enabled auto-merge (squash) April 17, 2023 06:45
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:46 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 17, 2023 06:48 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:48 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 17, 2023 06:48 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5807f92
Status: ✅  Deploy successful!
Preview URL: https://bd52ab9a.affine.pages.dev
Branch Preview URL: https://fix-ui.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -25.23 ⚠️

Comparison is base (19894aa) 75.38% compared to head (5807f92) 50.15%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1981       +/-   ##
===========================================
- Coverage   75.38%   50.15%   -25.23%     
===========================================
  Files         278      220       -58     
  Lines        5382     4169     -1213     
  Branches     1050      888      -162     
===========================================
- Hits         4057     2091     -1966     
- Misses       1089     1897      +808     
+ Partials      236      181       -55     
Flag Coverage Δ
e2etest ?
storybook-test 50.63% <ø> (ø)
unittest 45.70% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/pure/workspace-slider-bar/style.ts 59.25% <ø> (-3.71%) ⬇️

... and 197 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@QiShaoXuan QiShaoXuan merged commit 143a55a into master Apr 17, 2023
@QiShaoXuan QiShaoXuan deleted the fix/ui branch April 17, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants