Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable slider bar link item drag #2010

Merged
merged 1 commit into from Apr 18, 2023
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 18, 2023

Using some css properties that are not very compatible may be risky.

@vercel
Copy link

vercel bot commented Apr 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
affine-preview 🔄 Building (Inspect) Apr 18, 2023 7:07am
affine-storybook 🔄 Building (Inspect) Apr 18, 2023 7:07am

@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:07 — with GitHub Actions Inactive
@JimmFly JimmFly requested a review from himself65 April 18, 2023 07:07
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:09 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (c895c18) 75.73% compared to head (dac2c5c) 75.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2010      +/-   ##
==========================================
+ Coverage   75.73%   75.81%   +0.07%     
==========================================
  Files         280      280              
  Lines        5498     5499       +1     
  Branches     1046     1040       -6     
==========================================
+ Hits         4164     4169       +5     
+ Misses       1096     1092       -4     
  Partials      238      238              
Flag Coverage Δ
e2etest 74.60% <ø> (+0.10%) ⬆️
server-test 94.16% <ø> (ø)
storybook-test 50.63% <ø> (ø)
unittest 45.62% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/pure/workspace-slider-bar/style.ts 62.96% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:12 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 18, 2023 07:12 — with GitHub Actions Inactive
@himself65 himself65 merged commit 9406335 into master Apr 18, 2023
20 of 23 checks passed
@himself65 himself65 deleted the chore/disable-link-drag branch April 18, 2023 07:16
@vercel vercel bot temporarily deployed to Preview – affine-preview April 18, 2023 07:16 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 18, 2023 07:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants