Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move theme switch and language switch to editor option menu #2025

Merged
merged 20 commits into from Apr 28, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 19, 2023

Close #2009

2023-04-28.18.12.17.mov

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 28, 2023 9:41am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 9:41am

@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly changed the title feat:move theme switch and language switch to editor option menu feat: move theme switch and language switch to editor option menu Apr 19, 2023
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1014683
Status: ✅  Deploy successful!
Preview URL: https://d89808a9.affine.pages.dev
Branch Preview URL: https://feat-move-theme-switch.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:40 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:42 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:44 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:44 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:44 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 19, 2023 03:44 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 28.16% and project coverage change: -21.36 ⚠️

Comparison is base (903b6ea) 69.55% compared to head (1014683) 48.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2025       +/-   ##
===========================================
- Coverage   69.55%   48.19%   -21.36%     
===========================================
  Files         311      244       -67     
  Lines        6624     5361     -1263     
  Branches     1086      916      -170     
===========================================
- Hits         4607     2584     -2023     
- Misses       1809     2675      +866     
+ Partials      208      102      -106     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 49.55% <ø> (ø)
unittest 35.52% <28.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/blocksuite/workspace-header/header.tsx 38.70% <0.00%> (-58.27%) ⬇️
...ace-header/header-right-items/EditorOptionMenu.tsx 7.50% <13.63%> (-56.14%) ⬇️
...der/header-right-items/theme-mode-switch/index.tsx 11.11% <20.00%> (-34.35%) ⬇️
...ader/header-right-items/theme-mode-switch/style.ts 25.00% <33.33%> (-46.43%) ⬇️
...rkspace-header/header-right-items/LanguageMenu.tsx 37.50% <37.50%> (ø)
...c/components/blocksuite/workspace-header/styles.ts 51.72% <50.00%> (-40.28%) ⬇️

... and 207 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@perfsee
Copy link

perfsee bot commented Apr 19, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …-theme-switch                 +/- ##
===================================================================
< Bundle              4.27 MB        4.31 MB    +45.7 kB(+1.07%)   
< Initial JS          1.75 MB        1.78 MB    +26.6 kB(+1.52%)   
< Initial CSS         13.2 kB        16.7 kB   +3.53 kB(+26.81%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
< Packages                150            154                  +4   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …-theme-switch                 +/- ##
===================================================================
< Bundle              4.16 MB        4.21 MB    +45.7 kB(+1.10%)   
< Initial JS          1.65 MB        1.67 MB    +26.6 kB(+1.61%)   
< Initial CSS         13.2 kB        16.7 kB   +3.53 kB(+26.81%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
< Packages                150            154                  +4   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …-theme-switch                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 19, 2023 03:49 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 19, 2023 03:54 Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:00 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:08 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) April 28, 2023 09:13
@himself65 himself65 disabled auto-merge April 28, 2023 09:13
@himself65 himself65 temporarily deployed to development April 28, 2023 09:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:16 — with GitHub Actions Inactive
@github-actions github-actions bot added the app:electron Related to electron app label Apr 28, 2023
@himself65 himself65 temporarily deployed to development April 28, 2023 09:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 09:25 — with GitHub Actions Inactive
@himself65 himself65 merged commit 2ff5ef9 into master Apr 28, 2023
18 of 20 checks passed
@himself65 himself65 deleted the feat/move-theme-switch branch April 28, 2023 09:28
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 10:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app app:web
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move light/dark switch and language setting to page options menu
2 participants