Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace react-dnd to dnd-kit #2028

Merged
merged 11 commits into from Apr 21, 2023
Merged

feat: replace react-dnd to dnd-kit #2028

merged 11 commits into from Apr 21, 2023

Conversation

QiShaoXuan
Copy link
Contributor

@QiShaoXuan QiShaoXuan commented Apr 19, 2023

close #2030

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 07:57 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 07:57 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ❌ Failed (Inspect) Apr 21, 2023 4:12am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 4:12am

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 07:57 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 07:57 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 07:57 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 07:57 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 19, 2023 07:59 Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b777a28
Status:🚫  Build failed.

View logs

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:01 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 43.36% and project coverage change: +13.74 🎉

Comparison is base (44011b4) 61.77% compared to head (b777a28) 75.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2028       +/-   ##
===========================================
+ Coverage   61.77%   75.52%   +13.74%     
===========================================
  Files          82      296      +214     
  Lines        1473     5868     +4395     
  Branches      313     1071      +758     
===========================================
+ Hits          910     4432     +3522     
- Misses        562     1196      +634     
- Partials        1      240      +239     
Flag Coverage Δ
e2etest 73.70% <43.75%> (?)
server-test 90.78% <ø> (ø)
storybook-test 49.05% <6.18%> (-0.62%) ⬇️
unittest 44.99% <44.32%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/component/src/ui/tree-view/utils.ts 0.00% <0.00%> (ø)
...nt/src/ui/tree-view/hooks/useSelectWithKeyboard.ts 17.24% <17.24%> (ø)
packages/component/src/ui/tree-view/styles.ts 52.94% <33.33%> (+27.94%) ⬆️
...ponents/pure/workspace-slider-bar/shared-styles.ts 51.61% <50.00%> (ø)
packages/component/src/ui/tree-view/TreeView.tsx 64.28% <57.14%> (+61.78%) ⬆️
...kages/component/src/ui/tree-view/TreeNodeInner.tsx 61.53% <61.53%> (ø)
...s/component/src/ui/tree-view/hooks/useCollapsed.ts 61.53% <61.53%> (ø)
packages/component/src/ui/tree-view/TreeNode.tsx 62.96% <71.42%> (+54.19%) ⬆️
apps/web/src/components/affine/pinboard/styles.ts 63.33% <75.00%> (ø)

... and 261 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:01 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:01 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:01 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:01 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Apr 19, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master feat/tree-view                 +/- ##
===================================================================
> Bundle               4.3 MB        4.25 MB      -42 kB(-0.98%)   
> Initial JS          1.79 MB        1.75 MB    -41.3 kB(-2.31%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
> Packages                160            152                  -8   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master feat/tree-view                 +/- ##
===================================================================
> Bundle              4.19 MB        4.15 MB      -42 kB(-1.00%)   
> Initial JS          1.68 MB        1.64 MB    -41.3 kB(-2.45%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
> Packages                160            152                  -8   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master feat/tree-view                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:32 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:32 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:32 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 08:32 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 03:12 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 03:12 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 03:15 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:06 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:06 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:06 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:06 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:06 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:08 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 04:10 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:11 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:11 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:11 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 04:11 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 04:12 Inactive
@QiShaoXuan QiShaoXuan merged commit a5a6203 into master Apr 21, 2023
19 of 22 checks passed
@QiShaoXuan QiShaoXuan deleted the feat/tree-view branch April 21, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Uniform dnd frame(now we are using react-dnd and dnd-kit), unified use of dnd-kit
3 participants