Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify default avatar #2034

Merged
merged 9 commits into from Apr 20, 2023
Merged

feat: modify default avatar #2034

merged 9 commits into from Apr 20, 2023

Conversation

QiShaoXuan
Copy link
Contributor

close #1999

@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 20, 2023 9:02am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 9:02am

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:10 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 19, 2023 10:12 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 86.95% and project coverage change: -0.25 ⚠️

Comparison is base (227f59c) 76.29% compared to head (963a075) 76.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2034      +/-   ##
==========================================
- Coverage   76.29%   76.05%   -0.25%     
==========================================
  Files         292      294       +2     
  Lines        5843     5892      +49     
  Branches     1070     1072       +2     
==========================================
+ Hits         4458     4481      +23     
- Misses       1144     1169      +25     
- Partials      241      242       +1     
Flag Coverage Δ
e2etest 74.03% <92.85%> (-0.27%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 50.28% <62.50%> (-0.35%) ⬇️
unittest 45.26% <76.19%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ne/workspace-setting-detail/panel/general/style.ts 88.88% <ø> (ø)
...omponent/src/components/workspace-avatar/index.tsx 90.90% <ø> (-4.10%) ⬇️
.../src/components/workspace-avatar/DefaultAvatar.tsx 81.25% <81.25%> (ø)
...onent/src/components/workspace-avatar/index.css.ts 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:14 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:14 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:14 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 19, 2023 10:14 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 19, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 963a075
Status: ✅  Deploy successful!
Preview URL: https://15cbd38b.affine.pages.dev
Branch Preview URL: https://feat-avatar.affine.pages.dev

View logs

@QiShaoXuan QiShaoXuan enabled auto-merge (squash) April 19, 2023 10:16
@perfsee
Copy link

perfsee bot commented Apr 19, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master    feat/avatar                 +/- ##
===================================================================
> Bundle               4.3 MB        4.28 MB    -19.8 kB(-0.46%)   
< Initial JS          1.79 MB         1.9 MB     +106 kB(+5.92%)   
< Initial CSS         3.13 kB        4.72 kB   +1.59 kB(+50.91%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
> Assets                   43             41                  -2   
> Chunks                   41             39                  -2   
< Packages                160            162                  +2   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master    feat/avatar                 +/- ##
===================================================================
> Bundle              4.19 MB        4.17 MB    -19.7 kB(-0.47%)   
< Initial JS          1.68 MB        1.79 MB     +106 kB(+6.30%)   
< Initial CSS         3.13 kB        4.72 kB   +1.59 kB(+50.91%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
> Assets                   41             39                  -2   
> Chunks                   39             37                  -2   
< Packages                160            162                  +2   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master    feat/avatar                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 19, 2023 10:24 Inactive
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself is LGTM. But when I hover the mouse over the avatar, it will flash.

/cc @hwangdev97

Preview: https://affine-storybook-git-feat-avatar-toeverything.vercel.app/?path=/story/affine-workspaceavatar--basic

Feishu20230419-131908.mp4

@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 05:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 05:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 05:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 05:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:10 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:12 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:14 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:14 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:14 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:14 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 20, 2023 08:26 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:28 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:30 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:34 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:34 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:34 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 20, 2023 08:34 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 20, 2023 08:58 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 20, 2023 09:02 Inactive
@QiShaoXuan QiShaoXuan requested a review from JimmFly April 20, 2023 09:06
@QiShaoXuan QiShaoXuan merged commit 4a1c15c into master Apr 20, 2023
21 of 22 checks passed
@QiShaoXuan QiShaoXuan deleted the feat/avatar branch April 20, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

New default avatar​ components
3 participants