Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update temp disable affine cloud modal style #2046

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 20, 2023

work for #2044

@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly requested a review from QiShaoXuan April 20, 2023 06:26
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b872e3
Status: ✅  Deploy successful!
Preview URL: https://39d41e9d.affine.pages.dev
Branch Preview URL: https://chore-update-modal-style.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:28 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -0.13 ⚠️

Comparison is base (227f59c) 76.29% compared to head (9b872e3) 76.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   76.29%   76.17%   -0.13%     
==========================================
  Files         292      292              
  Lines        5843     5851       +8     
  Branches     1070     1065       -5     
==========================================
- Hits         4458     4457       -1     
- Misses       1144     1152       +8     
- Partials      241      242       +1     
Flag Coverage Δ
e2etest 74.15% <76.92%> (-0.15%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 50.43% <16.66%> (-0.20%) ⬇️
unittest 45.60% <46.15%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ts/affine/tmp-disable-affine-cloud-modal/index.tsx 25.00% <ø> (ø)
.../component/src/components/workspace-card/styles.ts 92.30% <ø> (ø)
packages/component/src/ui/empty/Empty.tsx 66.66% <ø> (ø)
packages/component/src/ui/empty/EmptySVG.tsx 100.00% <ø> (ø)
...nts/affine/tmp-disable-affine-cloud-modal/style.ts 58.33% <62.50%> (-13.10%) ⬇️
packages/component/src/ui/empty/style.ts 83.33% <83.33%> (-16.67%) ⬇️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 20, 2023 06:32 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Apr 20, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …e-modal-style                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB      +674 B(+0.02%)   
< Initial JS           1.9 MB         1.9 MB      +627 B(+0.03%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …e-modal-style                 +/- ##
===================================================================
< Bundle              4.17 MB        4.17 MB      +674 B(+0.02%)   
< Initial JS          1.79 MB        1.79 MB      +627 B(+0.04%)   
= Initial CSS         3.13 kB        3.13 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   39             39                       
= Chunks                   37             37                       
= Packages                162            162                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …e-modal-style                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 20, 2023 7:09am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 7:09am

@vercel vercel bot temporarily deployed to Preview – affine-preview April 20, 2023 06:52 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 20, 2023 07:09 Inactive
@JimmFly JimmFly requested a review from himself65 April 20, 2023 07:25
@himself65 himself65 merged commit 65c1bee into master Apr 20, 2023
@himself65 himself65 deleted the chore/update-modal-style branch April 20, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants