Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify with new blocksuite version about subpage #2060

Merged
merged 9 commits into from Apr 21, 2023
Merged

Conversation

QiShaoXuan
Copy link
Contributor

No description provided.

@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:29 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:30 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:30 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:30 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:30 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:30 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 67b3439
Status: ✅  Deploy successful!
Preview URL: https://adc3210b.affine.pages.dev
Branch Preview URL: https://fix-pinboard.affine.pages.dev

View logs

@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:33 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 21, 2023 8:17am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 8:17am

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 71.42% and project coverage change: -1.74 ⚠️

Comparison is base (01115f8) 75.55% compared to head (67b3439) 73.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
- Coverage   75.55%   73.81%   -1.74%     
==========================================
  Files         296      289       -7     
  Lines        5870     5397     -473     
  Branches     1079      849     -230     
==========================================
- Hits         4435     3984     -451     
+ Misses       1196     1184      -12     
+ Partials      239      229      -10     
Flag Coverage Δ
e2etest 73.94% <71.42%> (+0.23%) ⬆️
server-test 90.78% <ø> (ø)
storybook-test 48.72% <0.00%> (-0.34%) ⬇️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ffine/pinboard/pinboard-render/OperationButton.tsx 96.55% <ø> (+7.36%) ⬆️
packages/component/src/ui/tree-view/TreeView.tsx 46.15% <0.00%> (-18.14%) ⬇️
...ents/affine/pinboard/pinboard-render/AddButton.tsx 50.00% <50.00%> (ø)
apps/web/src/hooks/use-pinboard-handler.ts 56.25% <60.00%> (-12.87%) ⬇️
...eb/src/hooks/affine/use-block-suite-meta-helper.ts 73.68% <66.66%> (-18.32%) ⬇️
.../web/src/hooks/affine/use-reference-link-helper.ts 80.00% <80.00%> (ø)
apps/web/src/atoms/public-workspace/index.ts 80.00% <100.00%> (ø)
...components/affine/pinboard/pinboard-menu/index.tsx 95.00% <100.00%> (+4.67%) ⬆️
...mponents/affine/pinboard/pinboard-render/index.tsx 79.31% <100.00%> (-0.18%) ⬇️
...web/src/pages/workspace/[workspaceId]/[pageId].tsx 72.22% <100.00%> (ø)
... and 1 more

... and 105 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:36 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:36 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:36 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:36 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 05:41 Inactive
@perfsee
Copy link

perfsee bot commented Apr 21, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master   fix/pinboard                 +/- ##
===================================================================
< Bundle              4.26 MB        4.26 MB      +397 B(+0.01%)   
< Initial JS          1.74 MB        1.74 MB      +407 B(+0.02%)   
= Initial CSS         13.1 kB        13.1 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master   fix/pinboard                 +/- ##
===================================================================
< Bundle              4.15 MB        4.15 MB      +397 B(+0.01%)   
< Initial JS          1.64 MB        1.64 MB      +407 B(+0.02%)   
= Initial CSS         13.1 kB        13.1 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master   fix/pinboard                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 05:45 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:49 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:49 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 05:49 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 07:56 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 08:00 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:03 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:03 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:03 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:03 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan enabled auto-merge (squash) April 21, 2023 08:03
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:03 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:03 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:05 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:07 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 08:12 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 08:17 Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan temporarily deployed to development April 21, 2023 08:31 — with GitHub Actions Inactive
@QiShaoXuan QiShaoXuan merged commit 9ec6768 into master Apr 21, 2023
21 of 23 checks passed
@QiShaoXuan QiShaoXuan deleted the fix/pinboard branch April 21, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants