Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): remove edgeless mode padding #2061

Merged
merged 2 commits into from
Apr 21, 2023
Merged

fix(web): remove edgeless mode padding #2061

merged 2 commits into from
Apr 21, 2023

Conversation

alt1o
Copy link
Contributor

@alt1o alt1o commented Apr 21, 2023

fix #2004

@alt1o alt1o requested a review from himself65 April 21, 2023 07:03
@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 21, 2023 9:49am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 9:49am

@alt1o alt1o temporarily deployed to development April 21, 2023 07:03 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:03 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:03 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:03 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:03 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:03 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:05 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 07:07 Inactive
@perfsee
Copy link

perfsee bot commented Apr 21, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master   fix/bug-2004                 +/- ##
===================================================================
> Bundle              4.26 MB        4.26 MB      -143 B(-0.00%)   
> Initial JS          1.74 MB        1.74 MB      -233 B(-0.01%)   
< Initial CSS         13.1 kB        13.2 kB       +80 B(+0.61%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master   fix/bug-2004                 +/- ##
===================================================================
> Bundle              4.15 MB        4.15 MB      -143 B(-0.00%)   
> Initial JS          1.64 MB        1.64 MB      -233 B(-0.01%)   
< Initial CSS         13.1 kB        13.2 kB       +80 B(+0.61%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master   fix/bug-2004                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@alt1o alt1o temporarily deployed to development April 21, 2023 07:08 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:08 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:08 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 07:08 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -1.05 ⚠️

Comparison is base (5a12483) 75.54% compared to head (4cc079e) 74.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2061      +/-   ##
==========================================
- Coverage   75.54%   74.50%   -1.05%     
==========================================
  Files         296      298       +2     
  Lines        5871     5859      -12     
  Branches     1080     1067      -13     
==========================================
- Hits         4435     4365      -70     
- Misses       1197     1279      +82     
+ Partials      239      215      -24     
Flag Coverage Δ
e2etest 73.71% <100.00%> (-0.02%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 49.05% <100.00%> (+<0.01%) ⬆️
unittest 37.56% <0.00%> (-7.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponent/src/components/block-suite-editor/index.tsx 92.59% <100.00%> (+0.13%) ⬆️

... and 26 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4cc079e
Status: ✅  Deploy successful!
Preview URL: https://ce45ee92.affine.pages.dev
Branch Preview URL: https://fix-bug-2004.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 07:10 Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:43 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:43 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:43 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:43 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:43 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:43 — with GitHub Actions Inactive
@github-actions github-actions bot added the test label Apr 21, 2023
@alt1o alt1o temporarily deployed to development April 21, 2023 09:45 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 21, 2023 09:46 Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:49 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:49 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:49 — with GitHub Actions Inactive
@alt1o alt1o temporarily deployed to development April 21, 2023 09:49 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 21, 2023 09:49 Inactive
@alt1o alt1o requested a review from QiShaoXuan April 21, 2023 09:54
@alt1o alt1o merged commit acc5afd into master Apr 21, 2023
@alt1o alt1o deleted the fix/bug-2004 branch April 21, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Edgeless is still having a invisible border
2 participants