fix: try to sign macos #2066
Merged
fix: try to sign macos #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
+ Coverage 74.09% 74.14% +0.05%
==========================================
Files 299 299
Lines 5930 5930
Branches 1089 1082 -7
==========================================
+ Hits 4394 4397 +3
+ Misses 1314 1311 -3
Partials 222 222
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report in Codecov by Sentry. |
Deploying with Β
|
| Latest commit: |
4eafb2a
|
| Status: | Β β Β Deploy successful! |
| Preview URL: | https://46d76a89.affine.pages.dev |
| Branch Preview URL: | https://fix-sign-macos.affine.pages.dev |
affine-toeverythingBundle maindiff ------------------- Bundle Size Diff -------------------------
@@ EntryPoint: main @@
## master fix/sign-macos +/- ##
===================================================================
< Bundle 4.26 MB 4.26 MB +71 B(+0.00%)
< Initial JS 1.74 MB 1.74 MB +71 B(+0.00%)
= Initial CSS 13.2 kB 13.2 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 43 43
= Chunks 41 41
= Packages 150 150
= Duplicates 5 5
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_app @@
## master fix/sign-macos +/- ##
===================================================================
< Bundle 4.15 MB 4.15 MB +71 B(+0.00%)
< Initial JS 1.64 MB 1.64 MB +71 B(+0.00%)
= Initial CSS 13.2 kB 13.2 kB
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 41 41
= Chunks 39 39
= Packages 150 150
= Duplicates 5 5
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries
! Separate mixed content assets files
! Avoid non-minified assets
! Avoid cache wasting
@@ EntryPoint: pages/_error @@
## master fix/sign-macos +/- ##
===================================================================
= Bundle 16.7 kB 16.7 kB
= Initial JS 16.7 kB 16.7 kB
= Initial CSS 0 B 0 B
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets 2 2
= Chunks 2 2
= Packages 5 5
= Duplicates 0 0
...and more |
tzhangchi
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite3 seems not working properly to be bundled in CI. This PR fix it by replace with better-sqlite3.
π€ Generated by Copilot at 4eafb2a
Summary
ππ οΈπ
This pull request improves the app's performance, reliability, and compatibility by switching to
better-sqlite3for SQLite database operations, enhancing error handling and logging, supporting rebuilding native modules, and using theULFOformat for Linux packaging. It also updates the dependencies and configuration files accordingly.Walkthrough
sqlite3tobetter-sqlite3module for SQLite database operations (link,link,link,link,link,link,link,link,link)ULFOformat for Linux distribution using Electron Forge (link)electron-rebuildscript to rebuild native modules (link)yjsmodule from bundling process (link)electron-logmodule todevDependencies(link)