Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(y-indexeddb): alert user when write operation unfinished #2085

Merged
merged 3 commits into from Apr 22, 2023

Conversation

himself65
Copy link
Contributor

Related: #2084

@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 22, 2023 10:52pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2023 10:52pm

@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 22, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 172597d
Status: ✅  Deploy successful!
Preview URL: https://7ae4d71f.affine.pages.dev
Branch Preview URL: https://himself65-0422-op.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:01 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:03 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -26.82 ⚠️

Comparison is base (7d246f8) 73.90% compared to head (172597d) 47.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2085       +/-   ##
===========================================
- Coverage   73.90%   47.08%   -26.82%     
===========================================
  Files         298      241       -57     
  Lines        5963     4755     -1208     
  Branches     1100      934      -166     
===========================================
- Hits         4407     2239     -2168     
- Misses       1332     2378     +1046     
+ Partials      224      138       -86     
Flag Coverage Δ
e2etest ?
server-test 90.78% <ø> (ø)
storybook-test 49.05% <ø> (ø)
unittest 37.41% <81.81%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/y-indexeddb/src/index.ts 83.23% <81.81%> (-5.52%) ⬇️

... and 214 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:07 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Apr 22, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …elf65/0422-op                 +/- ##
===================================================================
< Bundle              4.26 MB        4.26 MB      +310 B(+0.01%)   
< Initial JS          1.75 MB        1.75 MB      +310 B(+0.02%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …elf65/0422-op                 +/- ##
===================================================================
< Bundle              4.16 MB        4.16 MB      +310 B(+0.01%)   
< Initial JS          1.64 MB        1.64 MB      +310 B(+0.02%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …elf65/0422-op                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@himself65 himself65 changed the title fix: alert user when write operation unfinished fix(y-indexeddb): alert user when write operation unfinished Apr 22, 2023
@himself65 himself65 temporarily deployed to development April 22, 2023 22:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:22 — with GitHub Actions Inactive
@github-actions github-actions bot added the test label Apr 22, 2023
@himself65 himself65 temporarily deployed to development April 22, 2023 22:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 22, 2023 22:27 — with GitHub Actions Inactive
@himself65 himself65 merged commit 2ad1b77 into master Apr 22, 2023
19 of 22 checks passed
@himself65 himself65 deleted the himself65/0422-op branch April 22, 2023 22:32
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 22, 2023 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 22, 2023 22:52 Inactive
@tzhangchi
Copy link
Contributor

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants