Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky in customElements #2109

Merged
merged 8 commits into from Apr 24, 2023
Merged

Conversation

himself65
Copy link
Contributor

Fixes: #2108

@himself65 himself65 temporarily deployed to development April 24, 2023 17:14 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 24, 2023 6:33pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 6:33pm

@himself65 himself65 temporarily deployed to development April 24, 2023 17:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:17 — with GitHub Actions Inactive
@perfsee
Copy link

perfsee bot commented Apr 24, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …424-use-jsdom                 +/- ##
===================================================================
< Bundle              4.27 MB        4.27 MB       +71 B(+0.00%)   
< Initial JS          1.75 MB        1.75 MB       +71 B(+0.00%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …424-use-jsdom                 +/- ##
===================================================================
< Bundle              4.16 MB        4.16 MB       +71 B(+0.00%)   
< Initial JS          1.65 MB        1.65 MB       +71 B(+0.00%)   
= Initial CSS         13.2 kB        13.2 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …424-use-jsdom                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview April 24, 2023 17:20 Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c53a903
Status:⚡️  Build in progress...

View logs

@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:22 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 24, 2023 17:24 Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 17:27 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +16.85 🎉

Comparison is base (b73e918) 73.92% compared to head (c0a1f0d) 90.78%.

❗ Current head c0a1f0d differs from pull request most recent head c53a903. Consider uploading reports for the commit c53a903 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2109       +/-   ##
===========================================
+ Coverage   73.92%   90.78%   +16.85%     
===========================================
  Files         298       12      -286     
  Lines        5980      434     -5546     
  Branches     1102       18     -1084     
===========================================
- Hits         4421      394     -4027     
+ Misses       1333       39     -1294     
+ Partials      226        1      -225     
Flag Coverage Δ
e2etest ?
server-test 90.78% <ø> (ø)
storybook-test ?
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 286 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 24, 2023 18:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:15 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:18 — with GitHub Actions Inactive
@himself65 himself65 merged commit ef8dea8 into master Apr 24, 2023
13 of 16 checks passed
@himself65 himself65 deleted the himself65/0424-use-jsdom branch April 24, 2023 18:18
@himself65 himself65 temporarily deployed to development April 24, 2023 18:20 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:20 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:20 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 24, 2023 18:20 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 24, 2023 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 24, 2023 18:33 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ReferenceError: customElements is not defined
1 participant