Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add changeLog to storybook #2118

Merged
merged 4 commits into from Apr 25, 2023
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 25, 2023

work for #1998

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 25, 2023 6:20am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 6:20am

@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:17 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:19 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 25, 2023 05:21 Inactive
@perfsee
Copy link

perfsee bot commented Apr 25, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …-to-storybook                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB    +10.4 kB(+0.24%)   
> Initial JS          1.75 MB        1.75 MB      -575 B(-0.03%)   
< Initial CSS         13.2 kB        14.7 kB   +1.52 kB(+11.56%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …-to-storybook                 +/- ##
===================================================================
< Bundle              4.16 MB        4.17 MB    +10.4 kB(+0.25%)   
> Initial JS          1.65 MB        1.65 MB      -575 B(-0.03%)   
< Initial CSS         13.2 kB        14.7 kB   +1.52 kB(+11.56%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …-to-storybook                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -1.29 ⚠️

Comparison is base (ad58b4d) 74.07% compared to head (d9b7b0f) 72.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
- Coverage   74.07%   72.78%   -1.29%     
==========================================
  Files         301      302       +1     
  Lines        6005     6005              
  Branches     1074     1074              
==========================================
- Hits         4448     4371      -77     
- Misses       1349     1417      +68     
- Partials      208      217       +9     
Flag Coverage Δ
e2etest 70.49% <63.63%> (-1.95%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 49.43% <83.33%> (+0.66%) ⬆️
unittest 35.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/pure/workspace-slider-bar/shared-styles.ts 100.00% <ø> (ø)
...kages/component/src/components/changeLog/index.tsx 83.33% <83.33%> (ø)
...ents/pure/workspace-slider-bar/changeLog/index.tsx 50.00% <100.00%> (-50.00%) ⬇️

... and 18 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d9b7b0f
Status: ✅  Deploy successful!
Preview URL: https://33eb8039.affine.pages.dev
Branch Preview URL: https://chore-add-changelog-to-story.affine.pages.dev

View logs

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 25, 2023 05:24 Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:37 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:39 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 25, 2023 05:41 Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 05:43 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 25, 2023 05:45 Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:10 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:13 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) April 25, 2023 06:13
@vercel vercel bot temporarily deployed to Preview – affine-preview April 25, 2023 06:16 Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:19 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 25, 2023 06:19 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 25, 2023 06:20 Inactive
@himself65 himself65 merged commit 3f1293c into master Apr 25, 2023
23 of 24 checks passed
@himself65 himself65 deleted the chore/add-changelog-to-storybook branch April 25, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants