Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme color #2124

Merged
merged 2 commits into from
Apr 25, 2023
Merged

fix: theme color #2124

merged 2 commits into from
Apr 25, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 25, 2023

close #2130

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 25, 2023 9:34am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2023 9:34am

@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:25 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:25 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:25 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:25 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:25 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:27 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 25, 2023 09:29 Inactive
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (a807647) 74.03% compared to head (505d43d) 74.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
+ Coverage   74.03%   74.07%   +0.03%     
==========================================
  Files         302      302              
  Lines        6005     6005              
  Branches     1074     1074              
==========================================
+ Hits         4446     4448       +2     
+ Misses       1349     1348       -1     
+ Partials      210      209       -1     
Flag Coverage Δ
e2etest 72.49% <ø> (+0.08%) ⬆️
server-test 90.78% <ø> (ø)
storybook-test 49.43% <ø> (ø)
unittest 35.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/workspace-setting-detail/panel/general/index.tsx 50.00% <ø> (ø)
apps/web/src/components/pure/help-island/style.ts 100.00% <ø> (ø)
packages/component/src/styles/theme.ts 71.42% <ø> (ø)
packages/component/src/ui/button/utils.ts 84.00% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 505d43d
Status: ✅  Deploy successful!
Preview URL: https://dafdbf9d.affine.pages.dev
Branch Preview URL: https://chore-fix-theme-color.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:32 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 25, 2023 09:32 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 25, 2023 09:34 Inactive
@perfsee
Copy link

perfsee bot commented Apr 25, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …x-theme-color                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB    +10.4 kB(+0.24%)   
> Initial JS          1.75 MB        1.75 MB      -651 B(-0.04%)   
< Initial CSS         13.2 kB        14.7 kB   +1.52 kB(+11.53%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …x-theme-color                 +/- ##
===================================================================
< Bundle              4.16 MB        4.17 MB    +10.4 kB(+0.25%)   
> Initial JS          1.65 MB        1.65 MB      -651 B(-0.04%)   
< Initial CSS         13.2 kB        14.7 kB   +1.52 kB(+11.53%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …x-theme-color                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@JimmFly
Copy link
Member Author

JimmFly commented Apr 25, 2023

work for #2130

@himself65 himself65 merged commit 1c41731 into master Apr 25, 2023
@himself65 himself65 deleted the chore/fix-theme-color branch April 25, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

color style css inspection
2 participants