Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add download tips banner #2151

Merged
merged 14 commits into from
May 9, 2023
Merged

feat: add download tips banner #2151

merged 14 commits into from
May 9, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 26, 2023

close #2038
close #2103

2023-05-09.23.00.41.mov

@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:43 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 2:54pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 2:54pm

@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:43 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:46 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 94.11% and project coverage change: -0.17 ⚠️

Comparison is base (3c97e01) 71.24% compared to head (4d9fa66) 71.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2151      +/-   ##
==========================================
- Coverage   71.24%   71.07%   -0.17%     
==========================================
  Files         317      321       +4     
  Lines        7094     7126      +32     
  Branches     1135     1128       -7     
==========================================
+ Hits         5054     5065      +11     
- Misses       1830     1854      +24     
+ Partials      210      207       -3     
Flag Coverage Δ
e2etest 67.85% <85.71%> (-0.38%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.36% <85.71%> (+0.15%) ⬆️
unittest 40.45% <45.45%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/blocksuite/workspace-header/header.tsx 94.11% <60.00%> (-2.76%) ⬇️
apps/web/src/atoms/guide.ts 86.66% <100.00%> (+3.33%) ⬆️
...ents/blocksuite/workspace-header/download-tips.tsx 100.00% <100.00%> (ø)
...t/src/components/affine-banner/browser-warning.tsx 100.00% <100.00%> (ø)
...t/src/components/affine-banner/download-client.tsx 100.00% <100.00%> (ø)
...omponent/src/components/affine-banner/index.css.ts 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:51 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 26, 2023 17:51 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d9fa66
Status: ✅  Deploy successful!
Preview URL: https://15df99d7.affine.pages.dev
Branch Preview URL: https://feat-add-download-tips.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:48 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 4, 2023 07:50 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 10:35 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 10:35 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 10:35 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 10:35 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 10:35 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 9, 2023 10:35 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 9, 2023 10:39 Inactive
@JimmFly JimmFly requested a review from himself65 May 9, 2023 14:37
@JimmFly JimmFly marked this pull request as ready for review May 9, 2023 14:37
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:46 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:48 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 9, 2023 14:50 Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 9, 2023 14:53 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 9, 2023 14:54 Inactive
@himself65 himself65 merged commit b978bb1 into master May 9, 2023
8 checks passed
@himself65 himself65 deleted the feat/add-download-tips branch May 9, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Banner for Online Demo ​ Add Banner for Online Demo
2 participants