Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update workspace setting button color #2169

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 27, 2023

Close #2137

@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 27, 2023 6:10am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 6:10am

@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:30 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:33 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.12 ⚠️

Comparison is base (606f665) 70.54% compared to head (1bf027f) 70.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2169      +/-   ##
==========================================
- Coverage   70.54%   70.43%   -0.12%     
==========================================
  Files         301      301              
  Lines        5996     5996              
  Branches     1070     1070              
==========================================
- Hits         4230     4223       -7     
- Misses       1556     1563       +7     
  Partials      210      210              
Flag Coverage Δ
e2etest 67.36% <ø> (-0.13%) ⬇️
server-test 90.78% <ø> (ø)
storybook-test 49.29% <66.66%> (+0.28%) ⬆️
unittest 35.58% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/component/src/ui/button/utils.ts 84.00% <66.66%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:36 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:36 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1bf027f
Status: ✅  Deploy successful!
Preview URL: https://0bd46942.affine.pages.dev
Branch Preview URL: https://chore-update-button-color.affine.pages.dev

View logs

@perfsee
Copy link

perfsee bot commented Apr 27, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …-button-color                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB    +13.6 kB(+0.32%)   
< Initial JS          1.75 MB        1.76 MB     +2.2 kB(+0.13%)   
< Initial CSS         13.2 kB        14.7 kB   +1.51 kB(+11.51%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …-button-color                 +/- ##
===================================================================
< Bundle              4.16 MB        4.18 MB    +13.6 kB(+0.33%)   
< Initial JS          1.65 MB        1.65 MB     +2.2 kB(+0.13%)   
< Initial CSS         13.2 kB        14.7 kB   +1.51 kB(+11.51%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …-button-color                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@JimmFly JimmFly enabled auto-merge (squash) April 27, 2023 05:58
@vercel vercel bot temporarily deployed to Preview – affine-preview April 27, 2023 06:06 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 27, 2023 06:10 Inactive
@JimmFly JimmFly requested a review from lawvs April 27, 2023 08:11
@JimmFly JimmFly merged commit 50006ef into master Apr 27, 2023
19 of 21 checks passed
@JimmFly JimmFly deleted the chore/update-button-color branch April 27, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

workspace settings button color
2 participants