Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update menu background color #2170

Merged
merged 6 commits into from Apr 27, 2023
Merged

chore: update menu background color #2170

merged 6 commits into from Apr 27, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 27, 2023

Close #2131
Close #2129

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 27, 2023 6:25pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 6:25pm

@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 05:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 06:02 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (50006ef) 46.37% compared to head (07cced1) 46.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2170      +/-   ##
==========================================
- Coverage   46.37%   46.32%   -0.05%     
==========================================
  Files         232      232              
  Lines        4643     4643              
  Branches      884      884              
==========================================
- Hits         2153     2151       -2     
- Misses       2390     2392       +2     
  Partials      100      100              
Flag Coverage Δ
server-test 90.78% <ø> (ø)
storybook-test 49.10% <ø> (-0.19%) ⬇️
unittest 35.58% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/affine/operation-menu-items/Export.tsx 7.14% <ø> (ø)
.../components/affine/operation-menu-items/MoveTo.tsx 11.11% <ø> (ø)
...ffine/pinboard/pinboard-render/OperationButton.tsx 2.70% <ø> (ø)
...space-setting-detail/panel/collaboration/index.tsx 8.82% <ø> (ø)
.../block-suite-page-list/page-list/OperationCell.tsx 5.12% <0.00%> (ø)
...ace-header/header-right-items/EditorOptionMenu.tsx 3.12% <ø> (ø)
...workspace-header/header-right-items/UserAvatar.tsx 27.27% <ø> (ø)
.../component/src/components/share-menu/ShareMenu.tsx 71.11% <ø> (ø)
packages/component/src/ui/button/utils.ts 84.00% <ø> (ø)
packages/component/src/ui/menu/styles.ts 28.00% <ø> (ø)
... and 1 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 27, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 07cced1
Status: ✅  Deploy successful!
Preview URL: https://9c5eca61.affine.pages.dev
Branch Preview URL: https://chore-update-helpisland.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 27, 2023 06:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 06:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 06:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 06:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 06:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 27, 2023 06:22 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 27, 2023 06:27 Inactive
@perfsee
Copy link

perfsee bot commented Apr 27, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …te-helpisland                 +/- ##
===================================================================
< Bundle              4.27 MB        4.28 MB    +13.2 kB(+0.31%)   
< Initial JS          1.75 MB        1.75 MB    +1.79 kB(+0.10%)   
< Initial CSS         13.2 kB        14.7 kB   +1.51 kB(+11.51%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …te-helpisland                 +/- ##
===================================================================
< Bundle              4.16 MB        4.18 MB    +13.2 kB(+0.32%)   
< Initial JS          1.65 MB        1.65 MB    +1.79 kB(+0.11%)   
< Initial CSS         13.2 kB        14.7 kB   +1.51 kB(+11.51%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
= Packages                150            150                       
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …te-helpisland                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@JimmFly JimmFly temporarily deployed to development April 27, 2023 08:34 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 08:34 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 08:34 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 08:34 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 08:34 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 08:34 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:05 — with GitHub Actions Inactive
@JimmFly JimmFly marked this pull request as ready for review April 27, 2023 09:07
@JimmFly JimmFly enabled auto-merge (squash) April 27, 2023 09:07
@JimmFly JimmFly requested a review from lawvs April 27, 2023 09:07
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:08 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 27, 2023 09:11 Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:13 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:13 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:13 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:13 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 27, 2023 09:13 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 27, 2023 09:15 Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 17:59 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:03 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 27, 2023 18:03 — with GitHub Actions Inactive
@JimmFly JimmFly merged commit f3cbe54 into master Apr 27, 2023
19 of 23 checks passed
@JimmFly JimmFly deleted the chore/update-helpisland branch April 27, 2023 18:06
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 27, 2023 18:19 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 27, 2023 18:25 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

White menu background color secondary background menu color
2 participants