Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable no-unused vars #2181

Merged
merged 6 commits into from
Apr 28, 2023
Merged

chore: enable no-unused vars #2181

merged 6 commits into from
Apr 28, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 temporarily deployed to development April 28, 2023 03:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:12 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 28, 2023 6:15am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 6:15am

@himself65 himself65 temporarily deployed to development April 28, 2023 03:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:12 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:14 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5b6e654
Status: ✅  Deploy successful!
Preview URL: https://162635cd.affine.pages.dev
Branch Preview URL: https://himself65-0427-no-unused.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 92.92% and project coverage change: +0.17 🎉

Comparison is base (549dddc) 69.41% compared to head (5b6e654) 69.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2181      +/-   ##
==========================================
+ Coverage   69.41%   69.58%   +0.17%     
==========================================
  Files         311      311              
  Lines        6617     6612       -5     
  Branches     1085     1084       -1     
==========================================
+ Hits         4593     4601       +8     
+ Misses       1817     1805      -12     
+ Partials      207      206       -1     
Flag Coverage Δ
e2etest 67.33% <100.00%> (+0.23%) ⬆️
server-test 73.14% <ø> (ø)
storybook-test 49.64% <88.37%> (-0.01%) ⬇️
unittest 35.49% <86.95%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../block-suite-page-list/page-list/OperationCell.tsx 55.00% <ø> (ø)
...suite/workspace-header/editor-mode-switch/style.ts 33.33% <ø> (ø)
...e/workspace-header/header-right-items/EditPage.tsx 75.00% <ø> (ø)
.../workspace-header/header-right-items/ShareMenu.tsx 52.94% <ø> (ø)
.../components/blocksuite/workspace-header/header.tsx 96.96% <ø> (ø)
apps/web/src/layouts/styles.ts 81.25% <ø> (ø)
packages/component/src/ui/button/styles.ts 75.60% <ø> (ø)
packages/component/src/ui/input/style.ts 37.50% <0.00%> (ø)
packages/component/src/ui/layout/Content.tsx 70.00% <ø> (ø)
packages/component/src/ui/menu/MenuItem.tsx 83.33% <ø> (ø)
... and 49 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 03:25 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 03:29 Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:30 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 03:33 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 03:35 Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:28 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:28 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 04:32 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 04:37 Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 04:55 — with GitHub Actions Inactive
@himself65 himself65 marked this pull request as ready for review April 28, 2023 04:56
@himself65 himself65 temporarily deployed to development April 28, 2023 04:57 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 05:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 05:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 05:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 05:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 05:04 — with GitHub Actions Inactive
@himself65 himself65 merged commit 70fbbb3 into master Apr 28, 2023
@himself65 himself65 deleted the himself65/0427-no-unused branch April 28, 2023 05:41
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 06:11 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 06:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants