Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update menu placement #2183

Merged
merged 1 commit into from Apr 28, 2023
Merged

chore: update menu placement #2183

merged 1 commit into from Apr 28, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Apr 28, 2023

No description provided.

@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:26 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
affine-preview 🔄 Building (Inspect) Apr 28, 2023 5:26am
affine-storybook 🔄 Building (Inspect) Apr 28, 2023 5:26am

@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:26 — with GitHub Actions Inactive
@JimmFly JimmFly requested a review from himself65 April 28, 2023 05:26
@JimmFly JimmFly enabled auto-merge (squash) April 28, 2023 05:26
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:29 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (549dddc) 69.56% compared to head (d1adfef) 69.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2183   +/-   ##
=======================================
  Coverage   69.56%   69.56%           
=======================================
  Files         311      311           
  Lines        6617     6617           
  Branches     1085     1085           
=======================================
  Hits         4603     4603           
- Misses       1808     1809    +1     
+ Partials      206      205    -1     
Flag Coverage Δ
e2etest 67.31% <ø> (+0.02%) ⬆️
server-test 73.14% <ø> (ø)
storybook-test 49.55% <ø> (-0.09%) ⬇️
unittest 35.51% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/affine/operation-menu-items/Export.tsx 78.57% <ø> (ø)
.../components/affine/operation-menu-items/MoveTo.tsx 11.11% <ø> (ø)
...ffine/pinboard/pinboard-render/OperationButton.tsx 2.70% <ø> (ø)
...space-setting-detail/panel/collaboration/index.tsx 52.94% <ø> (ø)
.../block-suite-page-list/page-list/OperationCell.tsx 55.00% <ø> (ø)
...ace-header/header-right-items/EditorOptionMenu.tsx 63.63% <ø> (ø)
...workspace-header/header-right-items/UserAvatar.tsx 75.00% <ø> (ø)
.../component/src/components/share-menu/ShareMenu.tsx 73.91% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d1adfef
Status: ✅  Deploy successful!
Preview URL: https://7bcd8823.affine.pages.dev
Branch Preview URL: https://chore-update-menu-placement.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:33 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:33 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:33 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:33 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development April 28, 2023 05:33 — with GitHub Actions Inactive
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@JimmFly JimmFly merged commit b6ca2aa into master Apr 28, 2023
23 of 25 checks passed
@JimmFly JimmFly deleted the chore/update-menu-placement branch April 28, 2023 05:40
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 05:52 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 05:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants