Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: guide atoms #2196

Merged
merged 5 commits into from
Apr 28, 2023
Merged

refactor: guide atoms #2196

merged 5 commits into from
Apr 28, 2023

Conversation

himself65
Copy link
Contributor

No description provided.

@himself65 himself65 temporarily deployed to development April 28, 2023 20:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:44 — with GitHub Actions Inactive
@himself65 himself65 changed the title Himself65/0428 refacotr tips refactor: guide atoms Apr 28, 2023
@himself65 himself65 temporarily deployed to development April 28, 2023 20:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:44 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:46 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Apr 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview Apr 28, 2023 8:58pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2023 8:58pm

@perfsee
Copy link

perfsee bot commented Apr 28, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …refacotr-tips                 +/- ##
===================================================================
< Bundle              4.27 MB        4.31 MB    +45.3 kB(+1.06%)   
< Initial JS          1.75 MB        1.78 MB    +26.3 kB(+1.50%)   
< Initial CSS         13.2 kB        16.7 kB   +3.59 kB(+27.32%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   43             43                       
= Chunks                   41             41                       
< Packages                150            154                  +4   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …refacotr-tips                 +/- ##
===================================================================
< Bundle              4.16 MB        4.21 MB    +45.3 kB(+1.09%)   
< Initial JS          1.65 MB        1.67 MB    +26.3 kB(+1.60%)   
< Initial CSS         13.2 kB        16.7 kB   +3.59 kB(+27.32%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                   41             41                       
= Chunks                   39             39                       
< Packages                150            154                  +4   
= Duplicates                5              5                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …refacotr-tips                 +/- ##
===================================================================
= Bundle              16.7 kB        16.7 kB                       
= Initial JS          16.7 kB        16.7 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1757d6a
Status: ✅  Deploy successful!
Preview URL: https://00a00f53.affine.pages.dev
Branch Preview URL: https://himself65-0428-refacotr-tips.affine.pages.dev

View logs

@himself65 himself65 temporarily deployed to development April 28, 2023 20:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:47 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -21.44 ⚠️

Comparison is base (31cccaf) 69.57% compared to head (1757d6a) 48.14%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2196       +/-   ##
===========================================
- Coverage   69.57%   48.14%   -21.44%     
===========================================
  Files         311      243       -68     
  Lines        6682     5361     -1321     
  Branches     1101      918      -183     
===========================================
- Hits         4649     2581     -2068     
- Misses       1825     2680      +855     
+ Partials      208      100      -108     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 49.51% <100.00%> (-0.23%) ⬇️
unittest 35.37% <26.66%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/blocksuite/workspace-header/index.tsx 8.33% <0.00%> (-70.84%) ⬇️
apps/web/src/atoms/guide.ts 33.33% <33.33%> (ø)
...ges/component/src/components/app-sidebar/index.tsx 65.21% <50.00%> (-12.06%) ⬇️
...omponent/src/components/app-sidebar/index.jotai.ts 100.00% <100.00%> (ø)

... and 209 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 temporarily deployed to development April 28, 2023 20:50 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook April 28, 2023 20:53 Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:54 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:54 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:54 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:54 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development April 28, 2023 20:54 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview April 28, 2023 20:58 Inactive
@himself65 himself65 merged commit 1031fbc into master Apr 28, 2023
@himself65 himself65 deleted the himself65/0428-refacotr-tips branch April 28, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant