Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix popover z-index #2215

Merged
merged 1 commit into from May 5, 2023
Merged

Conversation

MichaelYuhe
Copy link
Contributor

@MichaelYuhe MichaelYuhe commented May 3, 2023

Fixes: #2234

image

Fix issue #2205 z-index of the pop-over comoponent should not be smaller than the side bar component.

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview May 3, 2023 7:28pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 7:28pm

@vercel
Copy link

vercel bot commented May 3, 2023

@MichaelYuhe is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 3, 2023 08:55 Inactive
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not a good approach, this file is exported from design side I think.

@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:00 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:00 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:00 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:00 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:00 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) May 5, 2023 04:00
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:00 — with GitHub Actions Inactive
@himself65 himself65 disabled auto-merge May 5, 2023 04:00
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -21.37 ⚠️

Comparison is base (b036fe8) 69.54% compared to head (5ddd13f) 48.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2215       +/-   ##
===========================================
- Coverage   69.54%   48.18%   -21.37%     
===========================================
  Files         310      243       -67     
  Lines        6653     5361     -1292     
  Branches     1096      918      -178     
===========================================
- Hits         4627     2583     -2044     
- Misses       1821     2677      +856     
+ Partials      205      101      -104     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 49.77% <ø> (ø)
unittest 35.35% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/theme/src/index.ts 92.30% <ø> (ø)

... and 212 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 enabled auto-merge (squash) May 5, 2023 04:07
@himself65 himself65 removed the request for review from hwangdev97 May 5, 2023 04:10
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:11 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:11 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:11 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:11 — with GitHub Actions Inactive
@MichaelYuhe MichaelYuhe temporarily deployed to development May 5, 2023 04:11 — with GitHub Actions Inactive
@himself65 himself65 merged commit 8a617f9 into toeverything:master May 5, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

The UI of the backlinks is not as expected, maybe it is z-index related
2 participants