Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: workspace provider #2218

Merged
merged 8 commits into from May 3, 2023
Merged

refactor: workspace provider #2218

merged 8 commits into from May 3, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented May 3, 2023

Reduce the loading time of the workspace provider in advance, and modify the type of provider.

Upstream: toeverything/blocksuite#2389

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 11:15pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 11:15pm

@himself65 himself65 temporarily deployed to development May 3, 2023 21:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:39 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:41 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 3, 2023 21:42 Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 3, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 769bbb7
Status: ✅  Deploy successful!
Preview URL: https://5a655139.affine.pages.dev
Branch Preview URL: https://himself65-0503-provider.affine.pages.dev

View logs

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 82.00% and project coverage change: +0.30 🎉

Comparison is base (b036fe8) 69.54% compared to head (769bbb7) 69.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2218      +/-   ##
==========================================
+ Coverage   69.54%   69.85%   +0.30%     
==========================================
  Files         310      309       -1     
  Lines        6653     6468     -185     
  Branches     1096      978     -118     
==========================================
- Hits         4627     4518     -109     
+ Misses       1821     1739      -82     
- Partials      205      211       +6     
Flag Coverage Δ
e2etest 67.53% <72.44%> (+0.03%) ⬆️
server-test 73.14% <ø> (ø)
storybook-test ?
unittest 35.49% <59.25%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/blocksuite/index.ts 100.00% <ø> (ø)
...hooks/use-sync-router-with-current-workspace-id.ts 80.76% <ø> (ø)
packages/workspace/src/atom.ts 75.00% <ø> (ø)
packages/workspace/src/type.ts 100.00% <ø> (ø)
packages/workspace/src/utils.ts 60.00% <38.46%> (-12.73%) ⬇️
...orkspace/src/providers/broad-cast-channel/index.ts 87.30% <66.66%> (-2.18%) ⬇️
packages/workspace/src/providers/index.ts 78.89% <78.78%> (+13.24%) ⬆️
apps/web/src/blocksuite/providers/affine/index.ts 86.36% <80.00%> (-1.88%) ⬇️
apps/web/src/atoms/root.ts 95.55% <100.00%> (+2.45%) ⬆️
.../src/hooks/use-router-with-workspace-id-defense.ts 88.23% <100.00%> (+0.73%) ⬆️
... and 3 more

... and 63 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-preview May 3, 2023 21:46 Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:47 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:49 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:49 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:49 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:49 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 21:49 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 22:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 22:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 22:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 22:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 22:56 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 22:59 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 3, 2023 23:00 Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:02 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:04 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:04 — with GitHub Actions Inactive
@github-actions github-actions bot added the docs Improvements or additions to documentation label May 3, 2023
@himself65 himself65 temporarily deployed to development May 3, 2023 23:06 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 3, 2023 23:08 Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:09 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 3, 2023 23:09 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 3, 2023 23:15 Inactive
@himself65 himself65 merged commit 9096ac2 into master May 3, 2023
10 checks passed
@himself65 himself65 deleted the himself65/0503-provider branch May 3, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web docs Improvements or additions to documentation mod:store mod:workspace Related to workspace package:y-indexeddb
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant