Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove data-testid in production #2228

Merged
merged 8 commits into from May 5, 2023

Conversation

cijiugechu
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ❌ Failed (Inspect) May 5, 2023 4:52am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 4:52am

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 4, 2023 17:08 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 4, 2023 17:12 Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:20 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:20 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:20 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:20 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:20 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:20 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:22 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.22 ⚠️

Comparison is base (84b36c1) 70.49% compared to head (d95755e) 70.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
- Coverage   70.49%   70.28%   -0.22%     
==========================================
  Files         308      308              
  Lines        6768     6770       +2     
  Branches     1096     1098       +2     
==========================================
- Hits         4771     4758      -13     
- Misses       1802     1813      +11     
- Partials      195      199       +4     
Flag Coverage Δ
e2etest 67.33% <ø> (-0.27%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.08% <ø> (ø)
unittest 37.30% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/next.config.mjs 33.92% <0.00%> (-0.62%) ⬇️
apps/web/preset.config.mjs 66.66% <0.00%> (-13.34%) ⬇️
packages/env/src/config.ts 94.28% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:26 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:26 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:26 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:26 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 4, 2023 19:26 — with GitHub Actions Inactive
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest enabling it in the development environment, otherwise, our test cases will all fail

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 01:49 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 5, 2023 01:53 Inactive
@cijiugechu cijiugechu requested a review from himself65 May 5, 2023 02:10
@cijiugechu cijiugechu temporarily deployed to development May 5, 2023 03:27 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 5, 2023 03:27 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 5, 2023 03:27 — with GitHub Actions Inactive
@cijiugechu cijiugechu temporarily deployed to development May 5, 2023 03:27 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:46 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:48 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 03:51 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:06 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:08 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:11 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:14 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 5, 2023 04:14 — with GitHub Actions Inactive
@himself65 himself65 merged commit 92859bf into toeverything:master May 5, 2023
6 of 8 checks passed
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 04:48 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 5, 2023 04:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants