Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong menu position #2238

Merged
merged 2 commits into from
May 6, 2023
Merged

fix: wrong menu position #2238

merged 2 commits into from
May 6, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 5, 2023

Align the menu with the button

@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:54 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:54 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ❌ Failed (Inspect) May 5, 2023 10:21am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 10:21am

@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:56 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:59 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 04:59 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (fbbcb4b) 70.44% compared to head (8b1b494) 70.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2238      +/-   ##
==========================================
- Coverage   70.44%   70.32%   -0.12%     
==========================================
  Files         308      308              
  Lines        6770     6770              
  Branches     1098     1098              
==========================================
- Hits         4769     4761       -8     
- Misses       1800     1808       +8     
  Partials      201      201              
Flag Coverage Δ
e2etest 67.39% <ø> (-0.19%) ⬇️
server-test 73.14% <ø> (ø)
storybook-test 55.08% <ø> (+0.23%) ⬆️
unittest 37.30% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ace-header/header-right-items/EditorOptionMenu.tsx 64.28% <ø> (ø)
packages/component/src/ui/shared/Container.tsx 90.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 05:25 Inactive
@perfsee
Copy link

perfsee bot commented May 5, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …menu-position                 +/- ##
===================================================================
< Bundle              3.11 MB        3.13 MB      +16 kB(+0.51%)   
< Initial JS          1.86 MB        1.86 MB    +1.34 kB(+0.07%)   
< Initial CSS         16.8 kB        16.8 kB       +19 B(+0.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …menu-position                 +/- ##
===================================================================
< Bundle                 3 MB        3.01 MB    +14.9 kB(+0.50%)   
< Initial JS          1.75 MB        1.75 MB      +234 B(+0.01%)   
< Initial CSS         16.8 kB        16.8 kB       +19 B(+0.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …menu-position                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 5, 2023 05:30 Inactive
@cloudflare-pages
Copy link

cloudflare-pages bot commented May 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8b1b494
Status: ✅  Deploy successful!
Preview URL: https://26d5075a.affine.pages.dev
Branch Preview URL: https://fix-menu-position.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:02 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:02 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:02 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:03 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:03 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:03 — with GitHub Actions Inactive
@JimmFly JimmFly changed the title fix(UI): update menu position fix: wrong menu position May 5, 2023
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:05 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:07 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 5, 2023 10:17 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 10:21 Inactive
@himself65 himself65 merged commit aaa4b4f into master May 6, 2023
7 of 8 checks passed
@himself65 himself65 deleted the fix/menu-position branch May 6, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants