Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable navigation path #2243

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 5, 2023

Close #2121

@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:03 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ❌ Failed (Inspect) May 5, 2023 9:11am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 9:11am

@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:03 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:03 — with GitHub Actions Inactive
@JimmFly JimmFly enabled auto-merge (squash) May 5, 2023 09:03
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:03 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:03 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:03 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.28 🎉

Comparison is base (fbbcb4b) 70.44% compared to head (715181f) 71.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2243      +/-   ##
==========================================
+ Coverage   70.44%   71.73%   +1.28%     
==========================================
  Files         308      297      -11     
  Lines        6770     6587     -183     
  Branches     1098     1071      -27     
==========================================
- Hits         4769     4725      -44     
+ Misses       1800     1668     -132     
+ Partials      201      194       -7     
Flag Coverage Δ
e2etest 69.24% <ø> (+1.66%) ⬆️
server-test 73.14% <ø> (ø)
storybook-test 55.08% <ø> (+0.23%) ⬆️
unittest 37.30% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...b/src/components/pure/quick-search-modal/index.tsx 86.36% <ø> (+1.91%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 09:06 Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:07 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 09:07 — with GitHub Actions Inactive
@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 715181f
Status: ✅  Deploy successful!
Preview URL: https://020f55b1.affine.pages.dev
Branch Preview URL: https://chore-remove-navigationpath.affine.pages.dev

View logs

@perfsee
Copy link

perfsee bot commented May 5, 2023

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                       EntryPoint: main                        @@
##                     master …avigationPath                 +/- ##
===================================================================
< Bundle              3.11 MB        3.11 MB    +3.23 kB(+0.10%)   
> Initial JS          1.86 MB        1.85 MB    -7.61 kB(-0.41%)   
< Initial CSS         16.8 kB        16.8 kB       +19 B(+0.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   41             45                  +4   
< Chunks                   39             42                  +3   
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                    EntryPoint: pages/_app                     @@
##                     master …avigationPath                 +/- ##
===================================================================
< Bundle                 3 MB           3 MB    +2.12 kB(+0.07%)   
> Initial JS          1.75 MB        1.74 MB    -8.72 kB(-0.50%)   
< Initial CSS         16.8 kB        16.8 kB       +19 B(+0.11%)   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
< Assets                   39             43                  +4   
< Chunks                   37             40                  +3   
= Packages                132            132                       
= Duplicates                3              3                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Separate mixed content assets files                              
! Avoid non-minified assets                                        
! Avoid cache wasting                                              

@@                   EntryPoint: pages/_error                    @@
##                     master …avigationPath                 +/- ##
===================================================================
= Bundle              16.6 kB        16.6 kB                       
= Initial JS          16.6 kB        16.6 kB                       
= Initial CSS             0 B            0 B                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
= Assets                    2              2                       
= Chunks                    2              2                       
= Packages                  5              5                       
= Duplicates                0              0                       

...and more

@vercel vercel bot temporarily deployed to Preview – affine-preview May 5, 2023 09:11 Inactive
@JimmFly JimmFly merged commit 80c1f9e into master May 5, 2023
9 checks passed
@JimmFly JimmFly deleted the chore/remove-navigationPath branch May 5, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unexpected UI of quick search
2 participants