Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the style of help island in edgeless mode #2244

Merged
merged 2 commits into from
May 5, 2023

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented May 5, 2023

2023-05-05.17.59.52.mov

@cloudflare-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6f0356a
Status: ✅  Deploy successful!
Preview URL: https://b70b2370.affine.pages.dev
Branch Preview URL: https://chore-update-help-island-sty.affine.pages.dev

View logs

@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:00 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ❌ Failed (Inspect) May 5, 2023 10:03am
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 10:03am

@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:00 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:00 — with GitHub Actions Inactive
@JimmFly JimmFly changed the title chore: update help island style chore: update the style of help island in edgeless mode May 5, 2023
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:02 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 5, 2023 10:03 Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:04 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:04 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:04 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:04 — with GitHub Actions Inactive
@JimmFly JimmFly temporarily deployed to development May 5, 2023 10:04 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (fbbcb4b) 70.44% compared to head (6f0356a) 70.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
+ Coverage   70.44%   70.47%   +0.03%     
==========================================
  Files         308      309       +1     
  Lines        6770     6778       +8     
  Branches     1098     1099       +1     
==========================================
+ Hits         4769     4777       +8     
  Misses       1800     1800              
  Partials      201      201              
Flag Coverage Δ
e2etest 67.61% <100.00%> (+0.03%) ⬆️
server-test 73.14% <ø> (ø)
storybook-test 55.08% <ø> (+0.23%) ⬆️
unittest 37.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/web/src/components/pure/help-island/style.ts 100.00% <ø> (ø)
apps/web/src/components/pure/help-island/index.tsx 85.00% <100.00%> (+0.78%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@himself65 himself65 merged commit 1ef408c into master May 5, 2023
10 checks passed
@himself65 himself65 deleted the chore/update-help-island-style branch May 5, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants